Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 229343004: Revert 262516 "Remove title and icon from chrome apps native style title bars." (Closed)

Created:
6 years, 8 months ago by Matt Giuca
Modified:
6 years, 8 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Revert 262516 "Remove title and icon from chrome apps native style title bars." This CL causes conflicts with my pending CL (https://codereview.chromium.org/224903022) that needs to be merged into M35. The safest way forward is to revert this, commit my CL, then re-land this, dealing with the merge conflicts. BUG=357049 > Remove title and icon from chrome apps native style title bars. > > These windows aren't meant to have titles or icons, but still need to > get a proper title as far as the OS is concerned. This means using a > custom but glass frame, similarly to how unthemed browser windows look. > > BUG=339558 > TEST=Try out frame:chrome app windows windows on Windows 7, 8 and XP. > Use the windows in various states (maximised, fullscreen, normal). > Make sure they work after switching in and out of aero mode. > > Review URL: https://codereview.chromium.org/213743017 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -514 lines) Patch
M apps/ui/views/app_window_frame_view.h View 1 chunk +14 lines, -20 lines 0 comments Download
M apps/ui/views/app_window_frame_view.cc View 3 chunks +23 lines, -24 lines 0 comments Download
M apps/ui/views/native_app_window_views.h View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/browser/ui/views/apps/app_window_desktop_native_widget_aura_win.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/ui/views/apps/app_window_desktop_native_widget_aura_win.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chrome/browser/ui/views/apps/app_window_desktop_window_tree_host_win.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.h View 1 chunk +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views.cc View 6 chunks +58 lines, -31 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.h View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 6 chunks +2 lines, -37 lines 0 comments Download
D chrome/browser/ui/views/apps/glass_app_window_frame_view_win.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/ui/views/apps/glass_app_window_frame_view_win.cc View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/browser/ui/views/apps/shaped_app_window_targeter_unittest.cc View 4 chunks +3 lines, -13 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Matt Giuca
Hey Ben, Really sorry to do this. If you can think of a better way ...
6 years, 8 months ago (2014-04-09 09:25:58 UTC) #1
benwells
On 2014/04/09 09:25:58, Matt Giuca wrote: > Hey Ben, > > Really sorry to do ...
6 years, 8 months ago (2014-04-09 16:34:43 UTC) #2
benwells
lgtm
6 years, 8 months ago (2014-04-09 16:34:52 UTC) #3
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 8 months ago (2014-04-09 23:27:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/229343004/1
6 years, 8 months ago (2014-04-09 23:27:07 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 04:51:56 UTC) #6
Message was sent while issue was closed.
Change committed as 262915

Powered by Google App Engine
This is Rietveld 408576698