Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2293413004: trace-turbo should respect --redirect-code-traces (Closed)

Created:
4 years, 3 months ago by ofrobots
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

trace-turbo should respect --redirect-code-traces On larger workloads, lots of output on stdout becomes unwieldy. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/ce8fab7649eedaa1e658f340d0e99cc6251f8216 Cr-Commit-Position: refs/heads/master@{#39111}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -35 lines) Patch
M src/compiler/instruction.h View 4 chunks +11 lines, -10 lines 0 comments Download
M src/compiler/instruction.cc View 7 chunks +21 lines, -19 lines 0 comments Download
M src/compiler/pipeline.cc View 6 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ofrobots
4 years, 3 months ago (2016-09-01 18:39:45 UTC) #1
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-01 18:42:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293413004/1
4 years, 3 months ago (2016-09-01 23:25:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 23:27:36 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 23:28:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce8fab7649eedaa1e658f340d0e99cc6251f8216
Cr-Commit-Position: refs/heads/master@{#39111}

Powered by Google App Engine
This is Rietveld 408576698