Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 22934007: linux_aura: Fix crash on drags from the omnibox. (Closed)

Created:
7 years, 4 months ago by Elliot Glaysher
Modified:
7 years, 4 months ago
Reviewers:
sadrul, varunjain
CC:
chromium-reviews, tfarina, ben+watch_chromium.org
Visibility:
Public.

Description

linux_aura: Fix crash on drags from the omnibox. When we receive a mouse move event, there may be more events behind it in the queue. Prevent those further mouse events from also triggering a nested drag message loop. BUG=268797 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217757

Patch Set 1 #

Total comments: 2

Patch Set 2 : Switch to AutoReset #

Total comments: 1

Patch Set 3 : Add DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M ui/views/view.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/view.cc View 1 2 5 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Elliot Glaysher
https://codereview.chromium.org/22934007/diff/1/ui/views/view.cc File ui/views/view.cc (right): https://codereview.chromium.org/22934007/diff/1/ui/views/view.cc#newcode2329 ui/views/view.cc:2329: currently_dragging_ = true; I vaguely remember us having some ...
7 years, 4 months ago (2013-08-14 21:15:55 UTC) #1
sadrul
+varunjain@ I looked for some other way for a View to decide that a drag ...
7 years, 4 months ago (2013-08-14 21:33:51 UTC) #2
varunjain
On 2013/08/14 21:33:51, sadrul wrote: > +varunjain@ > > I looked for some other way ...
7 years, 4 months ago (2013-08-14 22:25:16 UTC) #3
sadrul
> There is aura specific aura::client::DragDropClient::IsDragDropInProgress(). > But I dont think there is a generic ...
7 years, 4 months ago (2013-08-14 22:49:28 UTC) #4
varunjain
On 2013/08/14 22:49:28, sadrul wrote: > > There is aura specific aura::client::DragDropClient::IsDragDropInProgress(). > > But ...
7 years, 4 months ago (2013-08-14 22:56:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erg@chromium.org/22934007/31001
7 years, 4 months ago (2013-08-14 23:14:26 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-15 07:09:30 UTC) #7
Message was sent while issue was closed.
Change committed as 217757

Powered by Google App Engine
This is Rietveld 408576698