Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2293383005: Print result returned by compare_files. (Closed)

Created:
4 years, 3 months ago by Yoshisato Yanagisawa
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, M-A Ruel
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Print result returned by compare_files. No differences on dependencies are shown with commit https://crrev.com/29b5fd95fd5f5b1e815cca5ef12c596a4e609620. That is because the code did not print difference at all. Let me print it if exists. Also, shows number of deps. BUG=314403 Committed: https://crrev.com/6eff2bed7163a176416d57301f14bc34c2fa1732 Cr-Commit-Position: refs/heads/master@{#415947}

Patch Set 1 #

Patch Set 2 : forgot to set max_filepath_len. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/determinism/compare_build_artifacts.py View 1 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Yoshisato Yanagisawa
4 years, 3 months ago (2016-09-01 08:19:51 UTC) #2
M-A Ruel
lgtm
4 years, 3 months ago (2016-09-01 13:07:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293383005/20001
4 years, 3 months ago (2016-09-01 13:07:55 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-01 14:23:51 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6eff2bed7163a176416d57301f14bc34c2fa1732 Cr-Commit-Position: refs/heads/master@{#415947}
4 years, 3 months ago (2016-09-01 14:26:51 UTC) #10
Dirk Pranke
4 years, 3 months ago (2016-09-01 19:27:29 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698