Remove unused prefs/api/resource for setPageEncoding

Remove unused prefs/api/resource for setPageEncoding

Interface WebView::setPageEncoding was mainly used to override

text encoding manually via UI. Now that UI is gone (see https://crrev.com/2254273003),
the interface is not used any more by chrome.

Also removed other preferences/resources that became unnecessary.

BUG=597488
Committed: https://crrev.com/c07e0137ca0c4ccd4d1d2205b09c28b3f35fa6dc
Cr-Commit-Position: refs/heads/master@{#416827}

[Jinsuk Kim, 2016-08-31 05:28:27]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 05:28:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 06:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 06:57:21]

Dry run: This issue passed the CQ dry run.

[Jinsuk Kim, 2016-08-31 07:07:06]

jinsukkim@chromium.org changed reviewers:
+ tkent@chromium.org

[Jinsuk Kim, 2016-08-31 07:07:07]

I'm not sure whether it is a common practice to remove Blink interface once it
is not used by Chrome or leave it in case it is needed for other clients.

[tkent, 2016-08-31 15:26:10]

On 2016/08/31 at 07:07:07, jinsukkim wrote:
> I'm not sure whether it is a common practice to remove Blink interface once it
is not used by Chrome or leave it in case it is needed for other clients.

In general it's ok to remove code unused by Chromium browser immediately.  If
other browsers need such code, we should discuss and might re-introduce the
code.

[tkent, 2016-08-31 15:30:58]

We should remove more.

- FrameHost::setOverrideEncoding()
- FrameHost::overrideEncoding()  It's always a null string.
- useEncodingDetector flag in core/frame/Settings.in.  It's always true.
- content::WebPreferences::use_universal_detector.  It's always true.
etc.

[Jinsuk Kim, 2016-08-31 22:50:19]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 22:50:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jinsuk Kim, 2016-08-31 23:08:33]

Description was changed from

==========
Remove WebView::setPageEncoding interface

The interface was mainly used to override text encoding manually
via UI. Now that UI is gone (see https://crrev.com/2254273003),
the interface is not used any more by chrome.

BUG=
==========

to

==========
Remove unused prefs/api/resource for setPageEncoding

Interface WebView::setPageEncoding was mainly used to override

text encoding manually via UI. Now that UI is gone (see
https://crrev.com/2254273003),
the interface is not used any more by chrome.

Also removed other preferences/resources that became unnecessary.
==========

[commit-bot: I haz the power, 2016-08-31 23:12:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 23:12:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jinsuk Kim, 2016-08-31 23:35:41]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[Jinsuk Kim, 2016-08-31 23:36:06]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-08-31 23:36:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 00:28:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 00:28:14]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Jinsuk Kim, 2016-09-01 03:38:51]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 03:39:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jinsuk Kim, 2016-09-01 03:39:07]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-09-01 04:57:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 04:57:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Jinsuk Kim, 2016-09-01 05:39:44]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 05:39:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jinsuk Kim, 2016-09-01 05:40:37]

Patchset #2 (id:60001) has been deleted

[commit-bot: I haz the power, 2016-09-01 07:08:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 07:08:04]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Jinsuk Kim, 2016-09-05 05:28:40]

Patchset #2 (id:80001) has been deleted

[Jinsuk Kim, 2016-09-05 05:43:14]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 05:43:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 07:19:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 07:19:47]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Jinsuk Kim, 2016-09-05 07:47:13]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-05 07:47:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 09:04:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-05 09:04:55]

Dry run: This issue passed the CQ dry run.

[Jinsuk Kim, 2016-09-05 09:48:18]

Patchset #2 (id:100001) has been deleted

[Jinsuk Kim, 2016-09-05 10:08:50]

PTAL

https://codereview.chromium.org/2293373002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp (right):

https://codereview.chromium.org/2293373002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp:140: //
Default encoding for XML content should remain as UTF-8 even if the
autodetection comes into play
This change was made to make following XML tests pass:

fast/encoding/default-xhtml-encoding.xhtml 
fast/encoding/meta-in-xhtml.xhtml
dom/xhtml/level3/core/documentgetinputencoding01.xhtml

[tkent, 2016-09-05 23:53:45]

https://codereview.chromium.org/2293373002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp (right):

https://codereview.chromium.org/2293373002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp:140: //
Default encoding for XML content should remain as UTF-8 even if the
autodetection comes into play
On 2016/09/05 at 10:08:50, Jinsuk wrote:
> This change was made to make following XML tests pass:
> 
> fast/encoding/default-xhtml-encoding.xhtml 
> fast/encoding/meta-in-xhtml.xhtml
> dom/xhtml/level3/core/documentgetinputencoding01.xhtml

Why did they fail?  Did the other part of this CL change an XML behavior?

[Jinsuk Kim, 2016-09-06 00:32:23]

On 2016/09/05 23:53:45, tkent wrote:
>
https://codereview.chromium.org/2293373002/diff/120001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp
(right):
> 
>
https://codereview.chromium.org/2293373002/diff/120001/third_party/WebKit/Sou...
> third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp:140: //
> Default encoding for XML content should remain as UTF-8 even if the
> autodetection comes into play
> On 2016/09/05 at 10:08:50, Jinsuk wrote:
> > This change was made to make following XML tests pass:
> > 
> > fast/encoding/default-xhtml-encoding.xhtml 
> > fast/encoding/meta-in-xhtml.xhtml
> > dom/xhtml/level3/core/documentgetinputencoding01.xhtml
> 
> Why did they fail?  Did the other part of this CL change an XML behavior?

It comes from the change in this line
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/loader/Te...

where the flag for autodetection |settings->usesEncodingDetector()| is changed
to set to true.

The tests checks XML charset meta tag are not honored, and unlabelled XML's
default encoding is UTF-8 and remain as such. Autodetection however sees them as
plain latin-1 text as there are no UTF-8-encoded chars in it, so the tests fail.
I don't know the history behind these tests. This comes close to a clue
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/pars...

Another approach to make the tests pass would be disable autodetection for XML.

[tkent, 2016-09-06 01:09:05]

On 2016/09/06 at 00:32:23, jinsukkim wrote:
> On 2016/09/05 23:53:45, tkent wrote:
> >
https://codereview.chromium.org/2293373002/diff/120001/third_party/WebKit/Sou...
> > File third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp
(right):
> > 
> >
https://codereview.chromium.org/2293373002/diff/120001/third_party/WebKit/Sou...
> > third_party/WebKit/Source/core/html/parser/TextResourceDecoder.cpp:140: //
> > Default encoding for XML content should remain as UTF-8 even if the
> > autodetection comes into play
> > On 2016/09/05 at 10:08:50, Jinsuk wrote:
> > > This change was made to make following XML tests pass:
> > > 
> > > fast/encoding/default-xhtml-encoding.xhtml 
> > > fast/encoding/meta-in-xhtml.xhtml
> > > dom/xhtml/level3/core/documentgetinputencoding01.xhtml
> > 
> > Why did they fail?  Did the other part of this CL change an XML behavior?
> 
> It comes from the change in this line
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/loader/Te...
> 
> where the flag for autodetection |settings->usesEncodingDetector()| is changed
to set to true.
> 
> The tests checks XML charset meta tag are not honored, and unlabelled XML's
default encoding is UTF-8 and remain as such. Autodetection however sees them as
plain latin-1 text as there are no UTF-8-encoded chars in it, so the tests fail.
I don't know the history behind these tests. This comes close to a clue
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/pars...
> 

Thanks. I understand.  These tests rely on encoding-detector=off, and this issue
is a user-visible regression by https://crrev.com/2254273003.
We shouldn't do dead code removal and a behavior change in a single CL.  So, I
recommend
 * Remove the TextResourceDecoder.cpp change from this CL, and mark the tests as
[ Failure ] in LayoutTests/TestExpectations
 * Make another CL to fix the tests.

> Another approach to make the tests pass would be disable autodetection for
XML.

I think this is a right approach.

[Jinsuk Kim, 2016-09-06 01:19:29]

Description was changed from

==========
Remove unused prefs/api/resource for setPageEncoding

Interface WebView::setPageEncoding was mainly used to override

text encoding manually via UI. Now that UI is gone (see
https://crrev.com/2254273003),
the interface is not used any more by chrome.

Also removed other preferences/resources that became unnecessary.
==========

to

==========
Remove unused prefs/api/resource for setPageEncoding

Interface WebView::setPageEncoding was mainly used to override

text encoding manually via UI. Now that UI is gone (see
https://crrev.com/2254273003),
the interface is not used any more by chrome.

Also removed other preferences/resources that became unnecessary.

BUG=597488
==========

[Jinsuk Kim, 2016-09-06 01:35:53]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 01:36:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Jinsuk Kim, 2016-09-06 02:01:04]

PTAL. Will have a follow-up CL ready that puts the suppressed layout tests back
on.

[tkent, 2016-09-06 02:07:47]

third_party/WebKit lgtm

[Jinsuk Kim, 2016-09-06 02:19:00]

jinsukkim@chromium.org changed reviewers:
+ kinuko@chromium.org, thestig@chromium.org

[Jinsuk Kim, 2016-09-06 02:19:00]

Could I have your owner's lgtm:

kinuko@chromium.org: Please review changes in content/

thestig@chromium.org: Please review changes in chrome/browser/

[Jinsuk Kim, 2016-09-06 02:21:12]

jinsukkim@chromium.org changed reviewers:
+ rickyz@chromium.org

[Jinsuk Kim, 2016-09-06 02:21:13]

rickyz@ Please review changes in
content/public/common/common_param_traits_macros.h

[commit-bot: I haz the power, 2016-09-06 02:55:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 02:55:31]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-06 19:03:40]

https://codereview.chromium.org/2293373002/diff/140001/chrome/browser/ui/pref...
File chrome/browser/ui/prefs/prefs_tab_helper.cc (right):

https://codereview.chromium.org/2293373002/diff/140001/chrome/browser/ui/pref...
chrome/browser/ui/prefs/prefs_tab_helper.cc:68: const char* kPrefsToObserve[] =
{
Can you make this a const char* const, while you are here?

https://codereview.chromium.org/2293373002/diff/140001/chrome/common/pref_nam...
File chrome/common/pref_names.h (left):

https://codereview.chromium.org/2293373002/diff/140001/chrome/common/pref_nam...
chrome/common/pref_names.h:142: extern const char
kWebKitUsesUniversalDetector[];
Do we need to do PrefService::ClearPref() like we did in
https://codereview.chromium.org/2254273003/ ?

[rickyz (no longer on Chrome), 2016-09-06 19:39:57]

content/public/common/common_param_traits_macros.h lgtm

[Jinsuk Kim, 2016-09-06 20:42:13]

https://codereview.chromium.org/2293373002/diff/140001/chrome/browser/ui/pref...
File chrome/browser/ui/prefs/prefs_tab_helper.cc (right):

https://codereview.chromium.org/2293373002/diff/140001/chrome/browser/ui/pref...
chrome/browser/ui/prefs/prefs_tab_helper.cc:68: const char* kPrefsToObserve[] =
{
On 2016/09/06 19:03:40, Lei Zhang wrote:
> Can you make this a const char* const, while you are here?

Done.

https://codereview.chromium.org/2293373002/diff/140001/chrome/common/pref_nam...
File chrome/common/pref_names.h (left):

https://codereview.chromium.org/2293373002/diff/140001/chrome/common/pref_nam...
chrome/common/pref_names.h:142: extern const char
kWebKitUsesUniversalDetector[];
On 2016/09/06 19:03:40, Lei Zhang wrote:
> Do we need to do PrefService::ClearPref() like we did in
> https://codereview.chromium.org/2254273003/ ?

That may be right. Thanks for catching it. Put the definition back in to clear
and mark it as deprecated. Also kept the registration in prefs_tab_helper.cc.

[Lei Zhang, 2016-09-06 20:44:53]

lgtm with nits.

https://codereview.chromium.org/2293373002/diff/160001/chrome/browser/prefs/b...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/2293373002/diff/160001/chrome/browser/prefs/b...
chrome/browser/prefs/browser_prefs.cc:751:
profile_prefs->ClearPref(prefs::kWebKitUsesUniversalDetector);
It's September. :)

https://codereview.chromium.org/2293373002/diff/160001/chrome/common/pref_nam...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2293373002/diff/160001/chrome/common/pref_nam...
chrome/common/pref_names.cc:322: // Deprecated 8/2016.
Ditto, September, unless there's a -144 timezone I don't know about. ;)

[Jinsuk Kim, 2016-09-06 20:46:25]

jinsukkim@chromium.org changed reviewers:
+ creis@chromium.org
- kinuko@chromium.org

[Jinsuk Kim, 2016-09-06 20:46:26]

creis@ could I have owner's seal for content/?

[Jinsuk Kim, 2016-09-06 21:19:40]

Thanks for dragging me out of the August

https://codereview.chromium.org/2293373002/diff/160001/chrome/browser/prefs/b...
File chrome/browser/prefs/browser_prefs.cc (right):

https://codereview.chromium.org/2293373002/diff/160001/chrome/browser/prefs/b...
chrome/browser/prefs/browser_prefs.cc:751:
profile_prefs->ClearPref(prefs::kWebKitUsesUniversalDetector);
On 2016/09/06 20:44:53, Lei Zhang wrote:
> It's September. :)

Still living in the (not-so-distant) past..

https://codereview.chromium.org/2293373002/diff/160001/chrome/common/pref_nam...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2293373002/diff/160001/chrome/common/pref_nam...
chrome/common/pref_names.cc:322: // Deprecated 8/2016.
On 2016/09/06 20:44:53, Lei Zhang wrote:
> Ditto, September, unless there's a -144 timezone I don't know about. ;)

Done.

[Charlie Reis, 2016-09-06 22:03:59]

content/ LGTM

[Jinsuk Kim, 2016-09-06 22:14:58]

The CQ bit was checked by jinsukkim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 22:15:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 02:23:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 02:23:22]

Dry run: This issue passed the CQ dry run.

[Jinsuk Kim, 2016-09-07 02:26:38]

The CQ bit was checked by jinsukkim@chromium.org

[Jinsuk Kim, 2016-09-07 02:26:38]

The patchset sent to the CQ was uploaded after l-g-t-m from rickyz@chromium.org,
tkent@chromium.org, thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2293373002/#ps180001
(title: "It's September!")

[commit-bot: I haz the power, 2016-09-07 02:26:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 02:34:02]

Description was changed from

==========
Remove unused prefs/api/resource for setPageEncoding

Interface WebView::setPageEncoding was mainly used to override

text encoding manually via UI. Now that UI is gone (see
https://crrev.com/2254273003),
the interface is not used any more by chrome.

Also removed other preferences/resources that became unnecessary.

BUG=597488
==========

to

==========
Remove unused prefs/api/resource for setPageEncoding

Interface WebView::setPageEncoding was mainly used to override

text encoding manually via UI. Now that UI is gone (see
https://crrev.com/2254273003),
the interface is not used any more by chrome.

Also removed other preferences/resources that became unnecessary.

BUG=597488
==========

[commit-bot: I haz the power, 2016-09-07 02:34:03]

Committed patchset #5 (id:180001)

[commit-bot: I haz the power, 2016-09-07 02:37:24]

Description was changed from

==========
Remove unused prefs/api/resource for setPageEncoding

Interface WebView::setPageEncoding was mainly used to override

text encoding manually via UI. Now that UI is gone (see
https://crrev.com/2254273003),
the interface is not used any more by chrome.

Also removed other preferences/resources that became unnecessary.

BUG=597488
==========

to

==========
Remove unused prefs/api/resource for setPageEncoding

Interface WebView::setPageEncoding was mainly used to override

text encoding manually via UI. Now that UI is gone (see
https://crrev.com/2254273003),
the interface is not used any more by chrome.

Also removed other preferences/resources that became unnecessary.

BUG=597488

Committed: https://crrev.com/c07e0137ca0c4ccd4d1d2205b09c28b3f35fa6dc
Cr-Commit-Position: refs/heads/master@{#416827}
==========

[commit-bot: I haz the power, 2016-09-07 02:37:26]

Patchset 5 (id:??) landed as
https://crrev.com/c07e0137ca0c4ccd4d1d2205b09c28b3f35fa6dc
Cr-Commit-Position: refs/heads/master@{#416827}