Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229333002: [Win] Unbreak the user manager tuturial that I broke in r259326. (Closed)

Created:
6 years, 8 months ago by noms (inactive)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

[Win] Unbreak the user manager tuturial that I broke in r259326. Broken in the sense that it no longer gets shown :) BUG=NONE TEST=With --new-profile-management enabled, create a new profile, and press the "Not X" button. The user manager should show up, and it should display a tutorial. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262818

Patch Set 1 #

Total comments: 2

Patch Set 2 : msw nit #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/profiles/profile_window.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
noms (inactive)
6 years, 8 months ago (2014-04-09 15:05:48 UTC) #1
msw
lgtm with a minor comment. https://codereview.chromium.org/229333002/diff/1/chrome/browser/ui/views/profile_chooser_view.cc File chrome/browser/ui/views/profile_chooser_view.cc (right): https://codereview.chromium.org/229333002/diff/1/chrome/browser/ui/views/profile_chooser_view.cc#newcode566 chrome/browser/ui/views/profile_chooser_view.cc:566: profiles::ShowUserManagerMaybeWithTutorial( It seems like ...
6 years, 8 months ago (2014-04-09 16:38:52 UTC) #2
noms (inactive)
Good catch, thanks! https://codereview.chromium.org/229333002/diff/1/chrome/browser/ui/views/profile_chooser_view.cc File chrome/browser/ui/views/profile_chooser_view.cc (right): https://codereview.chromium.org/229333002/diff/1/chrome/browser/ui/views/profile_chooser_view.cc#newcode566 chrome/browser/ui/views/profile_chooser_view.cc:566: profiles::ShowUserManagerMaybeWithTutorial( Done. This affected the cocoa ...
6 years, 8 months ago (2014-04-09 16:51:40 UTC) #3
msw
Great, lgtm, but I'm not a cocoa or profiles owner.
6 years, 8 months ago (2014-04-09 17:31:45 UTC) #4
noms (inactive)
I see, you're an UI owners, that's why your lgtm stuck. Alexei, would you mind ...
6 years, 8 months ago (2014-04-09 17:34:18 UTC) #5
Alexei Svitkine (slow)
lgtm
6 years, 8 months ago (2014-04-09 17:38:19 UTC) #6
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 8 months ago (2014-04-09 17:52:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229333002/40001
6 years, 8 months ago (2014-04-09 17:52:19 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 21:15:05 UTC) #9
Message was sent while issue was closed. 
Change committed as 262818

Powered by Google App Engine
This is Rietveld 408576698