Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 22933006: Mark HStringCompareAndBranch as potentially causing GCs. (Closed)

Created:
7 years, 4 months ago by Michael Starzinger
Modified:
7 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Mark HStringCompareAndBranch as potentially causing GCs. This also adds a %SetAllocationTimout runtime function which helps to write regression tests that need to trigger a GC at a certain point in program execution. R=hpayer@chromium.org BUG=chromium:274438 TEST=mjsunit/regress/regress-crbug-274438 Committed: http://code.google.com/p/v8/source/detail?r=16205

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M src/heap.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap.cc View 1 chunk +3 lines, -3 lines 2 comments Download
M src/hydrogen-instructions.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-274438.js View 1 chunk +7 lines, -14 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 4 months ago (2013-08-16 13:37:05 UTC) #1
Hannes Payer (out of office)
prime LGTM https://codereview.chromium.org/22933006/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/22933006/diff/1/src/heap.cc#newcode4019 src/heap.cc:4019: { MaybeObject* maybe_result = AllocateRaw(size, space, space); ...
7 years, 4 months ago (2013-08-16 13:56:28 UTC) #2
Michael Starzinger
Committed patchset #1 manually as r16205.
7 years, 4 months ago (2013-08-16 15:10:21 UTC) #3
Michael Starzinger
7 years, 4 months ago (2013-08-16 15:10:53 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/22933006/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/22933006/diff/1/src/heap.cc#newcode4019
src/heap.cc:4019: { MaybeObject* maybe_result = AllocateRaw(size, space, space);
On 2013/08/16 13:56:28, Hannes Payer wrote:
> We should use AllocateRaw in all Allocate* functions. We should clean that up
in
> a follow-up CL.

Yes, I wholeheartedly agree. It's on my plate as a follow-up.

Powered by Google App Engine
This is Rietveld 408576698