Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: third_party/WebKit/Source/core/paint/BlockPainter.cpp

Issue 2293293003: Make CaretBase a DisplayItemClient. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BlockPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/BlockPainter.cpp b/third_party/WebKit/Source/core/paint/BlockPainter.cpp
index cfa0778334dca4821bd762e0ab94abd15cc7f7ab..9ed2ae8472e909a3a6aa4e0f8b065716df0915fc 100644
--- a/third_party/WebKit/Source/core/paint/BlockPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/BlockPainter.cpp
@@ -194,6 +194,10 @@ void BlockPainter::paintObject(const PaintInfo& paintInfo, const LayoutPoint& pa
// If the caret's node's layout object's containing block is this block, and the paint action is PaintPhaseForeground,
// then paint the caret.
+ // LOG(ERROR) << "Painting caret [bounds=" << bounds.toString() << ", obj=" << m_layoutBlock.debugName() << "].";
chrishtr 2016/09/01 15:00:13 remove these comments
wkorman 2016/09/01 23:40:41 Done.
+ // m_layoutBlock.showLayoutTreeForThis();
+ // TODO(wkorman): Consider moving recorder into caret, having caret be DisplayItemClient for itself,
chrishtr 2016/09/01 15:00:13 The recorder is already in CaretBase.
wkorman 2016/09/01 23:40:40 Done.
+ // and use logic in invalidateLocalCaretRect() for the caret visual rect.
if (paintPhase == PaintPhaseForeground && m_layoutBlock.hasCaret())
paintCarets(paintInfo, paintOffset);
}
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698