Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6534)

Unified Diff: chrome/browser/task_manager/sampling/shared_sampler_win.cc

Issue 2293293002: Two TaskManager tests are flaky on debug due to a DCHECK in SharedSampler (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/task_manager/sampling/shared_sampler_win.cc
diff --git a/chrome/browser/task_manager/sampling/shared_sampler_win.cc b/chrome/browser/task_manager/sampling/shared_sampler_win.cc
index 6dd6647272d7c6d6be2f193181de116293b2fb1f..4cd06e986356e47e9d70536d15eb17bc3df8475d 100644
--- a/chrome/browser/task_manager/sampling/shared_sampler_win.cc
+++ b/chrome/browser/task_manager/sampling/shared_sampler_win.cc
@@ -356,12 +356,13 @@ void SharedSampler::UnregisterCallbacks(base::ProcessId process_id) {
void SharedSampler::Refresh(base::ProcessId process_id, int64_t refresh_flags) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- DCHECK(callbacks_map_.find(process_id) != callbacks_map_.end());
DCHECK_NE(0, refresh_flags & GetSupportedFlags());
if (process_id == 0)
return;
+ DCHECK(callbacks_map_.find(process_id) != callbacks_map_.end());
+
if (refresh_flags_ == 0) {
base::PostTaskAndReplyWithResult(
blocking_pool_runner_.get(), FROM_HERE,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698