Add a download button to the media player

third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
index 7b3cb56bd34b823b2c7f678f2f789f2210cad641..30e34a95c221467669cc8c50637a56bfc245ac93 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
@@ -627,6 +627,42 @@ void MediaControlOverflowMenuListElement::defaultEventHandler(Event* event)
 }
 
 // ----------------------------
+MediaControlDownloadButtonElement::MediaControlDownloadButtonElement(MediaControls& mediaControls)
+    : MediaControlInputElement(mediaControls, MediaDownloadButton)
+{
+}
+
+MediaControlDownloadButtonElement* MediaControlDownloadButtonElement::create(MediaControls& mediaControls, Document* document)
+{
+    MediaControlDownloadButtonElement* button = new MediaControlDownloadButtonElement(mediaControls);
+    button->ensureUserAgentShadowRoot();
+    button->setType(InputTypeNames::button);
+    button->setShadowPseudoId(AtomicString("-internal-download-button"));
+    button->setIsWanted(false);
+    return button;
+}
+
+WebLocalizedString::Name MediaControlDownloadButtonElement::getOverflowStringName()
+{
+    return WebLocalizedString::OverflowMenuDownload;
+}
+
+bool MediaControlDownloadButtonElement::shouldDisplayDownloadButton()
+{
+    const KURL& url = mediaElement().currentSrc();
+    if (!HTMLMediaElement::isMediaStreamURL(url.getString()) && !url.protocolIs("blob") && !HTMLMediaSource::lookup(url)) {

[mlamouri (slow - plz ping), 2016/09/12 11:06:25]

Will trust avayvod@ on this :)

+        return true;
+    }

[mlamouri (slow - plz ping), 2016/09/12 11:06:25]

style: no { }

[kdsilva, 2016/09/12 17:25:49]

Done.

+    return false;
+}
+
+void MediaControlDownloadButtonElement::defaultEventHandler(Event* event)
+{
+    // TODO(kdsilva): cr.bug/601247 The implementation for this download button

[mlamouri (slow - plz ping), 2016/09/12 11:06:25]

nit: cr.bug => https://crbug.com/

I would change the comment to: "implementation will be finished as part of
https://crbug.com/..."

[kdsilva, 2016/09/12 17:25:49]

Done.

+    // will be written in a CL imminently.
+}
+
+// ----------------------------
 
 MediaControlTimelineElement::MediaControlTimelineElement(MediaControls& mediaControls)
     : MediaControlInputElement(mediaControls, MediaSlider)