Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1238)

Issue 2293253007: X87: [Interpreter] Collect type feedback for 'new' in the bytecode handler. (Closed)

Created:
4 years, 3 months ago by zhengxing.li
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [Interpreter] Collect type feedback for 'new' in the bytecode handler. port 7e5b8feed307288d602c11cb4fb1184cbbc21d5a (r39120) original commit message: Collect type feedback in the bytecode handler for 'new' bytecode. The earlier cl (https://codereview.chromium.org/2153433002/) was reverted because that implementation did not collect allocation site feedback. This regressed delta blue by an order of magnitude. This implementation includes collection of allocation site feedback. Reland of https://codereview.chromium.org/2190293003/ with a bug fix. BUG= Committed: https://crrev.com/6d7ba1013700cf6437761a669e95099db46e730d Cr-Commit-Position: refs/heads/master@{#39145}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -28 lines) Patch
M src/builtins/x87/builtins-x87.cc View 3 chunks +108 lines, -27 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 3 months ago (2016-09-02 09:32:21 UTC) #2
mythria
Thanks for porting. lgtm.
4 years, 3 months ago (2016-09-02 14:40:20 UTC) #3
Weiliang
lgtm
4 years, 3 months ago (2016-09-03 13:31:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293253007/1
4 years, 3 months ago (2016-09-04 13:31:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-04 13:53:31 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-04 13:54:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d7ba1013700cf6437761a669e95099db46e730d
Cr-Commit-Position: refs/heads/master@{#39145}

Powered by Google App Engine
This is Rietveld 408576698