Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2293253002: [DevTools] Do not register log dispatcher (Closed)

Created:
4 years, 3 months ago by eostroukhov
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Do not register log dispatcher R=dgozman@chromium.org BUG= Committed: https://crrev.com/58e8f0529bcdcd96e271501c20b6c739ff8a262b Cr-Commit-Position: refs/heads/master@{#415528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
eostroukhov
Followup CL to 2297803002. This CL addresses a comment received after that CL was submitted.
4 years, 3 months ago (2016-08-30 23:43:25 UTC) #2
dgozman
lgtm
4 years, 3 months ago (2016-08-30 23:53:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293253002/1
4 years, 3 months ago (2016-08-31 00:07:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 01:29:07 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 01:30:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/58e8f0529bcdcd96e271501c20b6c739ff8a262b
Cr-Commit-Position: refs/heads/master@{#415528}

Powered by Google App Engine
This is Rietveld 408576698