Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 229323003: Modifies handling of hotword NaCl module. (Closed)

Created:
6 years, 8 months ago by Jun Mukai
Modified:
6 years, 8 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, arv+watch_chromium.org, rpetterson, gshires1
Visibility:
Public.

Description

Modifies handling of hotword NaCl module. This will break the behavior with the older version of the hotword, but actually that is fine because anyways the app-launcher hasn't worked well with the older version for other reasons. BUG=356873 R=xiyuan@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -13 lines) Patch
M chrome/browser/resources/app_list/plugin_manager.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/app_list/speech_manager.js View 4 chunks +33 lines, -3 lines 0 comments Download
M chrome/browser/resources/app_list/start_page.js View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_handler.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/app_list/start_page_ui.cc View 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Jun Mukai
6 years, 8 months ago (2014-04-08 23:18:30 UTC) #1
xiyuan
LGTM We probably want to explore whether we could have an api to use the ...
6 years, 8 months ago (2014-04-08 23:32:25 UTC) #2
Jun Mukai
On 2014/04/08 23:32:25, xiyuan wrote: > LGTM > > We probably want to explore whether ...
6 years, 8 months ago (2014-04-09 00:48:17 UTC) #3
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 8 months ago (2014-04-09 20:57:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/229323003/1
6 years, 8 months ago (2014-04-09 20:58:12 UTC) #5
Jun Mukai
The CQ bit was unchecked by mukai@chromium.org
6 years, 8 months ago (2014-04-09 21:06:41 UTC) #6
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 8 months ago (2014-04-10 02:55:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/229323003/1
6 years, 8 months ago (2014-04-10 02:55:51 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 04:42:50 UTC) #9
Message was sent while issue was closed.
Change committed as 262911

Powered by Google App Engine
This is Rietveld 408576698