Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2293203002: Remove unused resources chrome/android. (Closed)

Created:
4 years, 3 months ago by estevenson
Modified:
4 years, 3 months ago
Reviewers:
Ted C, Xi Han, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused resources from chrome/android. BUG=621773 Committed: https://crrev.com/d98ce7f7c02119c0882f1bb65cba20852f1cb410 Cr-Commit-Position: refs/heads/master@{#415674}

Patch Set 1 #

Patch Set 2 : Remove unused file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M build/android/lint/suppressions.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 3 chunks +1 line, -7 lines 0 comments Download
D chrome/android/webapk/shell_apk/res/layout/main.xml View 1 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
estevenson
agrieve@chromium.org: Please review changes in build/ hanxi@chromium.org: Please review changes in chrome/android/webapk tedchoc@chromium.org: Please review ...
4 years, 3 months ago (2016-08-31 01:03:30 UTC) #10
agrieve
On 2016/08/31 01:03:30, estevenson wrote: > mailto:agrieve@chromium.org: Please review changes in build/ > > mailto:hanxi@chromium.org: ...
4 years, 3 months ago (2016-08-31 01:33:19 UTC) #11
Xi Han
webapk lgtm
4 years, 3 months ago (2016-08-31 13:28:49 UTC) #12
Ted C
On 2016/08/31 13:28:49, Xi Han wrote: > webapk lgtm lgtm
4 years, 3 months ago (2016-08-31 17:29:04 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293203002/20001
4 years, 3 months ago (2016-08-31 17:31:42 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 17:36:28 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 17:38:46 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d98ce7f7c02119c0882f1bb65cba20852f1cb410
Cr-Commit-Position: refs/heads/master@{#415674}

Powered by Google App Engine
This is Rietveld 408576698