Issue 22932004: Adding missing operator!= for Handle and Persistent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22932004: Adding missing operator!= for Handle and Persistent. (Closed)

Created:
7 years, 4 months ago by marja

Modified:
7 years, 4 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Adding missing operator!= for Handle and Persistent. BUG= R=mstarzinger@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16255

Patch Set 2 : unify signatures #

Total comments: 2

Patch Set 3 : renamed test #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -3 lines)			Patch
	M	include/v8.h	View	1	3 chunks	+19 lines, -3 lines	0 comments	Download
	M	test/cctest/test-api.cc	View	1 2	1 chunk	+38 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/22932004/diff/3001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/22932004/diff/3001/test/cctest/test-api.cc#newcode3191 test/cctest/test-api.cc:3191: THREADED_TEST(LocalHandleBasedOnGlobalHandle) { nit: Maybe we should call the ...

7 years, 4 months ago (2013-08-21 09:54:09 UTC) #2

marja

https://codereview.chromium.org/22932004/diff/3001/test/cctest/test-api.cc File test/cctest/test-api.cc (right): https://codereview.chromium.org/22932004/diff/3001/test/cctest/test-api.cc#newcode3191 test/cctest/test-api.cc:3191: THREADED_TEST(LocalHandleBasedOnGlobalHandle) { On 2013/08/21 09:54:09, Michael Starzinger wrote: > ...

7 years, 4 months ago (2013-08-21 09:56:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r16255.