Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1935)

Unified Diff: ash/root_window_controller.h

Issue 2293183002: ash: Remove ash::Shelf in favor of ash::WmShelf (Closed)
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/root_window_controller.h
diff --git a/ash/root_window_controller.h b/ash/root_window_controller.h
index 740d0802083fd91f3f2b2808949effa88ec2f419..cff7b39d846ba8c01f6502b34b9df079fecade71 100644
--- a/ash/root_window_controller.h
+++ b/ash/root_window_controller.h
@@ -56,7 +56,6 @@ class DockedWindowLayoutManager;
enum class LoginStatus;
class PanelLayoutManager;
class RootWindowControllerCommon;
-class Shelf;
class ShelfLayoutManager;
class ShelfWidget;
class StackingController;
@@ -186,10 +185,6 @@ class ASH_EXPORT RootWindowController : public ShellObserver {
// Creates the shelf for this root window and notifies observers.
void CreateShelf();
- // Returns the shelf controller for this root window.
- // TODO(jamescook): Remove this and use WmRootWindowController::GetShelf().
- Shelf* GetShelf() const;
-
// Called when the login status changes after login (such as lock/unlock).
// TODO(oshima): Investigate if we can merge this and |OnLoginStateChanged|.
void UpdateAfterLoginStatusChange(LoginStatus status);
@@ -279,10 +274,8 @@ class ASH_EXPORT RootWindowController : public ShellObserver {
// to it during construction of the shelf widget and status tray.
std::unique_ptr<WmShelfAura> wm_shelf_aura_;
- // Legacy shelf controller. Only present after shelf is created (post-login).
- std::unique_ptr<Shelf> shelf_;
-
// The shelf widget for this root window.
+ // TODO(jamescook): Move ownership to WmShelf.
std::unique_ptr<ShelfWidget> shelf_widget_;
// An invisible/empty window used as a event target for

Powered by Google App Engine
This is Rietveld 408576698