Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: chrome/browser/predictors/resource_prefetcher_unittest.cc

Issue 2293153002: Remove stl_util's STLDeleteContainerPairFirstPointers. (Closed)
Patch Set: fixing Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/predictors/resource_prefetcher_unittest.cc
diff --git a/chrome/browser/predictors/resource_prefetcher_unittest.cc b/chrome/browser/predictors/resource_prefetcher_unittest.cc
index e1576e2a52bf5e73878be44974724f0cf29d2a92..e1ba98d6d426196d21057d43d7ad66dea3485f21 100644
--- a/chrome/browser/predictors/resource_prefetcher_unittest.cc
+++ b/chrome/browser/predictors/resource_prefetcher_unittest.cc
@@ -106,18 +106,16 @@ class ResourcePrefetcherTest : public testing::Test {
net::URLRequest* GetInFlightRequest(const std::string& url_str) {
GURL url(url_str);
- for (std::list<Request*>::const_iterator it =
- prefetcher_->request_queue_.begin();
+ for (auto it = prefetcher_->request_queue_.begin();
pasko 2016/09/01 12:30:45 nit: while we are here, can you please also conver
it != prefetcher_->request_queue_.end(); ++it) {
EXPECT_NE((*it)->resource_url, url);
}
- for (std::map<net::URLRequest*, Request*>::const_iterator it =
- prefetcher_->inflight_requests_.begin();
+ for (auto it = prefetcher_->inflight_requests_.begin();
pasko 2016/09/01 12:30:45 ditto
it != prefetcher_->inflight_requests_.end(); ++it) {
if (it->first->original_url() == url)
return it->first;
}
- EXPECT_TRUE(false) << "Infligh request not found: " << url_str;
+ EXPECT_TRUE(false) << "Inflight request not found: " << url_str;
pasko 2016/09/01 12:30:45 nit: s/Inflight/In flight/
return NULL;
}

Powered by Google App Engine
This is Rietveld 408576698