Remove stl_util's STLDeleteContainerPairFirstPointers.

Remove stl_util's STLDeleteContainerPairFirstPointers.

BUG=555865
Committed: https://crrev.com/903d5af813daae016776b4b1608c88864fadcd38
Cr-Commit-Position: refs/heads/master@{#416061}

[Avi (use Gerrit), 2016-08-30 19:10:05]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 19:10:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:46:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:46:09]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-08-30 20:30:19]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 20:31:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:56:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 20:56:17]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Avi (use Gerrit), 2016-08-30 20:59:41]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 21:00:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 21:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:37:54]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Avi (use Gerrit), 2016-08-31 01:32:51]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 01:33:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 03:34:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 03:34:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Avi (use Gerrit), 2016-08-31 15:03:39]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 15:04:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 17:53:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 17:53:49]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Avi (use Gerrit), 2016-08-31 18:28:58]

The CQ bit was checked by avi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 18:29:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:47:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:47:06]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-08-31 19:48:45]

avi@chromium.org changed reviewers:
+ benwells@chromium.org, mark@chromium.org, mattm@chromium.org,
pasko@chromium.org

[Avi (use Gerrit), 2016-08-31 19:48:46]

mark for base
mattm for safe_browsing
pasko for predictors
benwells for extensions

[mattm, 2016-08-31 21:10:36]

safe_browsing lgtm

[pasko, 2016-09-01 12:30:45]

predictors lgtm with nits

https://codereview.chromium.org/2293153002/diff/80001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetcher.h (right):

https://codereview.chromium.org/2293153002/diff/80001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetcher.h:10: #include <algorithm>
nit: std::pair is in <utility>, including that would be preferable

https://codereview.chromium.org/2293153002/diff/80001/chrome/browser/predicto...
File chrome/browser/predictors/resource_prefetcher_unittest.cc (right):

https://codereview.chromium.org/2293153002/diff/80001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetcher_unittest.cc:109: for (auto it =
prefetcher_->request_queue_.begin();
nit: while we are here, can you please also convert it to a range-based loop?

https://codereview.chromium.org/2293153002/diff/80001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetcher_unittest.cc:113: for (auto it =
prefetcher_->inflight_requests_.begin();
ditto

https://codereview.chromium.org/2293153002/diff/80001/chrome/browser/predicto...
chrome/browser/predictors/resource_prefetcher_unittest.cc:118:
EXPECT_TRUE(false) << "Inflight request not found: " << url_str;
nit: s/Inflight/In flight/

[Mark Mentovai, 2016-09-01 14:44:09]

LGTM inb ase

[Avi (use Gerrit), 2016-09-01 18:15:34]

avi@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, reillyg@chromium.org

[Avi (use Gerrit), 2016-09-01 18:15:34]

+Devlin, Reilly

Can I get a quick LG on the extensions files here?

[Devlin, 2016-09-01 18:21:57]

Nice, lgtm!

[Avi (use Gerrit), 2016-09-01 18:24:07]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2016-09-01 18:24:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 21:29:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-09-01 21:33:13]

Description was changed from

==========
Remove stl_util's STLDeleteContainerPairFirstPointers.

BUG=555865
==========

to

==========
Remove stl_util's STLDeleteContainerPairFirstPointers.

BUG=555865

Committed: https://crrev.com/903d5af813daae016776b4b1608c88864fadcd38
Cr-Commit-Position: refs/heads/master@{#416061}
==========

[commit-bot: I haz the power, 2016-09-01 21:33:15]

Patchset 5 (id:??) landed as
https://crrev.com/903d5af813daae016776b4b1608c88864fadcd38
Cr-Commit-Position: refs/heads/master@{#416061}