Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2293143003: Revert "Remove 'Element.docRange'." (Closed)

Created:
4 years, 3 months ago by pquitslund
Modified:
4 years, 3 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove 'Element.docRange'." This reverts commit abc5051854fd7c98c7ba6b593211e47dcbcec9e8. Background: required to keep `analyzer` version-compatible with `test`. BUG= R=brianwilkerson@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/b7f0ce083bbd931a16cb5cbeee2d14fbb52c91f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -43 lines) Patch
M pkg/analyzer/CHANGELOG.md View 1 chunk +0 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/dart/element/element.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 11 chunks +114 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/handle.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_dart.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 6 chunks +47 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 17 chunks +53 lines, -28 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/tool/summary/generate.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 3 months ago (2016-08-30 19:56:31 UTC) #2
scheglov
lgtm
4 years, 3 months ago (2016-08-30 20:03:21 UTC) #3
Brian Wilkerson
lgtm
4 years, 3 months ago (2016-08-30 20:05:11 UTC) #4
pquitslund
4 years, 3 months ago (2016-08-30 20:10:23 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b7f0ce083bbd931a16cb5cbeee2d14fbb52c91f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698