Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

Issue 22931003: File manager drive API: handle case where no default task is associated. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Toni's comments. Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
index d0d410055e252e1a477a7e9c4782deaf62411908..91dcbfdc21af5d79479081ef340961f01ab5642f 100644
--- a/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
@@ -142,10 +142,8 @@ void GetDriveEntryPropertiesFunction::OnGetFileInfo(
file_specific_info.content_mime_type(),
file_path_.Extension());
file_tasks::TaskDescriptor default_task;
- if (!file_tasks::ParseTaskID(default_task_id, &default_task)) {
- LOG(WARNING) << "Invalid task ID: " << default_task_id;
- return;
- }
+ file_tasks::ParseTaskID(default_task_id, &default_task);
+ DCHECK(default_task_id.empty() || !default_task.app_id.empty());
ListValue* apps = new ListValue();
properties_->Set("driveApps", apps);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698