File manager drive API: handle case where no default task is associated.

chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/file_manager/private_api_drive.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/chromeos/drive/drive_app_registry.h"
 #include "chrome/browser/chromeos/drive/drive_integration_service.h"
@@ skipping 124 matching lines @@
   // Get drive WebApps that can accept this file.
   ScopedVector<drive::DriveAppInfo> drive_apps;
   integration_service->drive_app_registry()->GetAppsForFile(
       file_path_, file_specific_info.content_mime_type(), &drive_apps);
   if (!drive_apps.empty()) {
     std::string default_task_id = file_tasks::GetDefaultTaskIdFromPrefs(
         profile_,
         file_specific_info.content_mime_type(),
         file_path_.Extension());
     file_tasks::TaskDescriptor default_task;
-    if (!file_tasks::ParseTaskID(default_task_id, &default_task)) {
-      LOG(WARNING) << "Invalid task ID: " << default_task_id;
-      return;
-    }
+    file_tasks::ParseTaskID(default_task_id, &default_task);

[tbarzic, 2013/08/12 21:09:49]

afaik, ParseTaskID should never fail for non-empty default_task_id, so it may be
useful to add something along the line of:

DCHECK(default_task_id.empty() || !default_task.app_id.empty());

[hshi1, 2013/08/12 21:13:41]

Done.

 
     ListValue* apps = new ListValue();
     properties_->Set("driveApps", apps);
     for (ScopedVector<drive::DriveAppInfo>::const_iterator it =
              drive_apps.begin();
          it != drive_apps.end(); ++it) {
       const drive::DriveAppInfo* app_info = *it;
       DictionaryValue* app = new DictionaryValue();
       app->SetString("appId", app_info->app_id);
       app->SetString("appName", app_info->app_name);
@@ skipping 532 matching lines @@
     error_ = "Share Url for this item is not available.";
     SendResponse(false);
     return;
   }
 
   SetResult(new base::StringValue(share_url.spec()));
   SendResponse(true);
 }
 
 }  // namespace file_manager