Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: components/tracing/test/proto_zero_generation_unittest.cc

Issue 2293073002: Tracing V2: Proto fields reflection. (Closed)
Patch Set: nit Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/tracing/test/proto_zero_generation_unittest.cc
diff --git a/components/tracing/test/proto_zero_generation_unittest.cc b/components/tracing/test/proto_zero_generation_unittest.cc
index 715b91fa26fb023f98867583b1fea75cb2772213..f34b71b56dea2b1ad2128a7e974c01d85ad06f2e 100644
--- a/components/tracing/test/proto_zero_generation_unittest.cc
+++ b/components/tracing/test/proto_zero_generation_unittest.cc
@@ -24,6 +24,7 @@ using tracing::v2::ProtoZeroMessage;
using tracing::v2::ScatteredStreamWriter;
using tracing::v2::ProtoZeroMessageHandle;
using tracing::v2::ProtoZeroMessageHandleBase;
+using tracing::v2::proto::ProtoFieldDescriptor;
constexpr size_t kChunkSize = 42;
@@ -155,7 +156,7 @@ TEST(ProtoZeroTest, Simple) {
EXPECT_LE(0u, sizeof(pbtest::TrickyPublicImport));
}
-TEST(ProtoZeroTest, FieldNumbers) {
+TEST(ProtoZeroTest, Reflection) {
// Tests camel case conversion as well.
EXPECT_EQ(1, pbtest::CamelCaseFields::kFooBarBazFieldNumber);
EXPECT_EQ(2, pbtest::CamelCaseFields::kBarBazFieldNumber);
@@ -166,6 +167,17 @@ TEST(ProtoZeroTest, FieldNumbers) {
EXPECT_EQ(7, pbtest::CamelCaseFields::kBigBangFieldNumber);
EXPECT_EQ(8, pbtest::CamelCaseFields::kU2FieldNumber);
EXPECT_EQ(9, pbtest::CamelCaseFields::kBangBigFieldNumber);
+
+ const ProtoFieldDescriptor* reflection =
+ pbtest::EveryField::GetFieldDescriptor(
+ pbtest::EveryField::kFieldInt32FieldNumber);
+ EXPECT_STREQ("field_int32", reflection->name());
+ EXPECT_EQ(ProtoFieldDescriptor::Type::TYPE_INT32, reflection->type());
+ EXPECT_EQ(1u, reflection->number());
+ EXPECT_FALSE(reflection->is_repeated());
+ EXPECT_TRUE(reflection->is_valid());
+
+ EXPECT_FALSE(pbtest::TransgalacticParcel::GetFieldDescriptor(42)->is_valid());
}
} // namespace proto
« no previous file with comments | « components/tracing/core/proto_utils.h ('k') | components/tracing/tools/proto_zero_plugin/proto_zero_generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698