Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2712)

Unified Diff: components/tracing/test/proto_zero_generation_unittest.cc

Issue 2293073002: Tracing V2: Proto fields reflection. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/tracing/test/proto_zero_generation_unittest.cc
diff --git a/components/tracing/test/proto_zero_generation_unittest.cc b/components/tracing/test/proto_zero_generation_unittest.cc
index 715b91fa26fb023f98867583b1fea75cb2772213..f8ea644b63f1901e4dade429f699f1b13bcd832e 100644
--- a/components/tracing/test/proto_zero_generation_unittest.cc
+++ b/components/tracing/test/proto_zero_generation_unittest.cc
@@ -24,6 +24,8 @@ using tracing::v2::ProtoZeroMessage;
using tracing::v2::ScatteredStreamWriter;
using tracing::v2::ProtoZeroMessageHandle;
using tracing::v2::ProtoZeroMessageHandleBase;
+using tracing::v2::proto::FieldReflection;
+using tracing::v2::proto::ProtoType;
constexpr size_t kChunkSize = 42;
@@ -155,7 +157,7 @@ TEST(ProtoZeroTest, Simple) {
EXPECT_LE(0u, sizeof(pbtest::TrickyPublicImport));
}
-TEST(ProtoZeroTest, FieldNumbers) {
+TEST(ProtoZeroTest, Reflection) {
// Tests camel case conversion as well.
EXPECT_EQ(1, pbtest::CamelCaseFields::kFooBarBazFieldNumber);
EXPECT_EQ(2, pbtest::CamelCaseFields::kBarBazFieldNumber);
@@ -166,6 +168,16 @@ TEST(ProtoZeroTest, FieldNumbers) {
EXPECT_EQ(7, pbtest::CamelCaseFields::kBigBangFieldNumber);
EXPECT_EQ(8, pbtest::CamelCaseFields::kU2FieldNumber);
EXPECT_EQ(9, pbtest::CamelCaseFields::kBangBigFieldNumber);
+
+ FieldReflection reflection =
+ pbtest::EveryField::GetFieldReflection(
+ pbtest::EveryField::kFieldInt32FieldNumber);
+ EXPECT_EQ("field_int32", reflection.name);
+ EXPECT_EQ(ProtoType::kProtoTypeInt32, reflection.type);
+ EXPECT_EQ(1u, reflection.number);
+ EXPECT_FALSE(reflection.repeated);
+
+ EXPECT_FALSE(pbtest::TransgalacticParcel::GetFieldReflection(42).IsValid());
}
} // namespace proto

Powered by Google App Engine
This is Rietveld 408576698