Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2293063002: Detect TSAN instead of relying on #ifdef THREAD_SANITIZER. (Closed)

Created:
4 years, 3 months ago by mtklein_C
Modified:
4 years, 3 months ago
Reviewers:
herb_g
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Detect TSAN instead of relying on #ifdef THREAD_SANITIZER. And reindent. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2293063002 CQ_INCLUDE_TRYBOTS=master.client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN-Trybot Committed: https://skia.googlesource.com/skia/+/e6ec16356ec677e582230002bd3ffab46fd14a49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -50 lines) Patch
M gyp/common_conditions.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkSharedMutex.cpp View 1 chunk +51 lines, -47 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mtklein_C
4 years, 3 months ago (2016-08-30 16:51:41 UTC) #6
herb_g
lgtm
4 years, 3 months ago (2016-08-30 17:36:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293063002/1
4 years, 3 months ago (2016-08-30 17:44:28 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:45:20 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e6ec16356ec677e582230002bd3ffab46fd14a49

Powered by Google App Engine
This is Rietveld 408576698