Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 2293023002: Add unmodified task_queue.h to webrtc_overrides (Closed)

Created:
4 years, 3 months ago by perkj_chrome
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add unmodified task_queue.h to webrtc_overrides The purpose is to be able to override the webrtc TaskQueue implementation in Chrome. The plan 1. First land unmodified task_queue.h file to Chrome 2. Modify build files in the webrtc repo to include the unmodified task_queue.h and not build task_queue.cc 3. Roll webrtc to Chrome 4. Reland https://codereview.chromium.org/2297643003/ that overrides task_queue in webrtc_overrides. 5. Modify the build files in webrtc to build webrtc_overrides/webrtc/base/task_queue.cc when build in chrome. 6. Roll again. 7. Build task_queue_unittest.cc as part of content_unittests to test task_queue.cc in webrtc_overrides. 8... Start using task queues in webrtc........ 9. Drink a beer and celebrate. BUG=webrtc:5687 TBR=tommi@chromium.org Committed: https://crrev.com/539910e4b91478bce27b2ad072f67af16c4c3cf7 Cr-Commit-Position: refs/heads/master@{#415301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -0 lines) Patch
A third_party/webrtc_overrides/webrtc/base/task_queue.h View 1 chunk +281 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
perkj_chrome
4 years, 3 months ago (2016-08-30 14:51:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293023002/1
4 years, 3 months ago (2016-08-30 15:35:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 15:38:46 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/539910e4b91478bce27b2ad072f67af16c4c3cf7 Cr-Commit-Position: refs/heads/master@{#415301}
4 years, 3 months ago (2016-08-30 15:40:18 UTC) #12
tommi (sloooow) - chröme
4 years, 3 months ago (2016-08-31 18:19:45 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698