bot_update/gclient: kill git fetch after timeout regardless of output.

bot_update/gclient: kill git fetch after timeout regardless of output.

Also spits out whatever output was produced by git fetch for debugging.

BUG=635641
R=machenbach@chromium.org,hinoka@chromium.org

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/db8b839320168ab4f5156399ecb275478c0aa2cd

[tandrii(chromium), 2016-08-30 14:35:31]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 14:35:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 14:42:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 14:42:10]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-08-30 14:48:43]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 14:48:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 14:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 14:55:19]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-08-30 15:02:52]

lgtm

https://codereview.chromium.org/2293013002/diff/20001/gclient_utils.py
File gclient_utils.py (right):

https://codereview.chromium.org/2293013002/diff/20001/gclient_utils.py#newcod...
gclient_utils.py:552: debug_kid_info = "'%s' in %s" % (' '.join('"%s"' % x for x
in args), run_cwd)
Wouldn't str(args) be sufficient?

Never mind. Saw now that it's copied from below.

https://codereview.chromium.org/2293013002/diff/20001/gclient_utils.py#newcod...
gclient_utils.py:569: timeout_killer = _KillTimer(kill_timeout, kid,
debug_kid_info)
naming nit: child vs. kid - well, it's from the old code...

[tandrii(chromium), 2016-08-30 15:03:46]

PTAL

FTR, I tested it with https://codereview.chromium.org/2297663002 and variations
of it.

[tandrii(chromium), 2016-08-30 15:07:59]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-08-30 15:08:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 15:11:04]

Description was changed from

==========
bot_update/gclient: kill git fetch after timeout regardless of output.

Also spits out whatever output was produced by git fetch for debugging.

BUG=635641
R=machenbach@chromium.org,hinoka@chromium.org
==========

to

==========
bot_update/gclient: kill git fetch after timeout regardless of output.

Also spits out whatever output was produced by git fetch for debugging.

BUG=635641
R=machenbach@chromium.org,hinoka@chromium.org

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/db8b839320168a...
==========

[commit-bot: I haz the power, 2016-08-30 15:11:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/db8b839320168a...

[tandrii(chromium), 2016-10-11 12:17:27]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2410053002/ by tandrii@chromium.org.

The reason for reverting is: didn't work..