Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2292983002: Don't add redundant references to animated target element (Closed)

Created:
4 years, 3 months ago by fs
Modified:
4 years, 3 months ago
Reviewers:
pdr.
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, krit, Eric Willigers, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't add redundant references to animated target element SVGSMILElement adds a reference to its target, and any instances of the target should never be mutated, so the registration of reference to the extended target element set in SVGAnimateElement::resetAnimatedType does not add any value. BUG=640676 Committed: https://crrev.com/c0d55affa1f3a57e3d8ec8c0911f56b2bbb54f27 Cr-Commit-Position: refs/heads/master@{#415393}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Source/core/svg/SVGAnimateElement.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
fs
4 years, 3 months ago (2016-08-30 14:25:49 UTC) #4
fs
(In case you are/were wondering - I was for a bit there - why this ...
4 years, 3 months ago (2016-08-30 15:45:38 UTC) #7
pdr.
On 2016/08/30 at 15:45:38, fs wrote: > (In case you are/were wondering - I was ...
4 years, 3 months ago (2016-08-30 17:27:03 UTC) #8
fs
On 2016/08/30 at 17:27:03, pdr wrote: > On 2016/08/30 at 15:45:38, fs wrote: > > ...
4 years, 3 months ago (2016-08-30 17:31:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292983002/1
4 years, 3 months ago (2016-08-30 17:31:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 19:26:46 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 19:30:37 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0d55affa1f3a57e3d8ec8c0911f56b2bbb54f27
Cr-Commit-Position: refs/heads/master@{#415393}

Powered by Google App Engine
This is Rietveld 408576698