Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2292963002: Add request type to FetchSuggestionsRequest. (Closed)

Created:
4 years, 3 months ago by Marc Treib
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Add request type to FetchSuggestionsRequest. There are two types of requests: interactive (e.g. a fetch when NTP is opened) and noninteractive (e.g. a background prefetch). The noninteractive requests are less important and thus they can be dropped first if needed. This CL adds request type to the request. BUG=638224 Review-Url: https://codereview.chromium.org/2271283002 Cr-Commit-Position: refs/heads/master@{#414672} (cherry picked from commit 2a444eb2c8fd642fb23bc2a1396bec823d9a515d) Committed: https://chromium.googlesource.com/chromium/src/+/c7a7d9659517e49f30824bd1f396c8ca213911bb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -19 lines) Patch
M components/ntp_snippets/ntp_snippets_fetcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_fetcher.cc View 10 chunks +21 lines, -13 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_fetcher_unittest.cc View 8 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 3 months ago (2016-08-30 12:37:32 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c7a7d9659517e49f30824bd1f396c8ca213911bb (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698