Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 2292933002: Renamed os_crypt_util_linux_unittest.cc to key_storage_libsecret_unittest.cc (Closed)

Created:
4 years, 3 months ago by cfroussios
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Renamed os_crypt_util_linux_unittest.cc to key_storage_libsecret_unittest.cc The current name of these tests did not reflect the component actually tested. It was also inconsistent with how the tests for the the other implementations of KeyStorage were named. Committed: https://crrev.com/eaf70ab37c2490c929fd40d52e504e3ff2e27d52 Cr-Commit-Position: refs/heads/master@{#415336}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -243 lines) Patch
M components/os_crypt/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + components/os_crypt/key_storage_libsecret_unittest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D components/os_crypt/os_crypt_util_linux_unittest.cc View 1 chunk +0 lines, -243 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
cfroussios
4 years, 3 months ago (2016-08-30 11:43:48 UTC) #5
Lei Zhang
lgtm
4 years, 3 months ago (2016-08-30 17:25:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292933002/1
4 years, 3 months ago (2016-08-30 17:25:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 17:30:13 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 17:32:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eaf70ab37c2490c929fd40d52e504e3ff2e27d52
Cr-Commit-Position: refs/heads/master@{#415336}

Powered by Google App Engine
This is Rietveld 408576698