Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229293004: Check in new Windows binary for breakpad symupload.exe. (Closed)

Created:
6 years, 8 months ago by Will Harris
Modified:
6 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Update symupload.exe to Breakpad's src/tools/windows/binaries/symupload.exe r1291. This binary includes recent changes to pdb_source_line_writer for emitting STACK CFI lines for 64bit PDBs. This was built using the GYP build files, MSVS 2013 and DIA SDK 12.0. NOTRY=true BUG=none R=mark@chromium.org TBR=mark@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
M breakpad/symupload.exe View Binary file 0 comments Download

Messages

Total messages: 41 (0 generated)
Will Harris
6 years, 8 months ago (2014-04-08 22:34:44 UTC) #1
Will Harris
The CQ bit was checked by wfh@chromium.org
6 years, 8 months ago (2014-04-09 00:26:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 00:26:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 00:37:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 01:00:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 01:12:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 01:31:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 01:42:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 01:52:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 02:03:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 02:20:48 UTC) #11
Mark Mentovai
LGTM
6 years, 8 months ago (2014-04-09 03:41:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 04:39:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 04:45:28 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 04:51:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 04:55:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 06:40:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 06:47:52 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 06:54:50 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 07:01:31 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 07:07:29 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 07:14:53 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 07:21:32 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 07:27:38 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 07:34:02 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 07:43:03 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 07:49:51 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 07:56:48 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 08:04:31 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 08:11:53 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 09:02:25 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 09:12:36 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 09:19:37 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 09:27:42 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 09:39:26 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 09:48:56 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 11:07:37 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wfh@chromium.org/229293004/1
6 years, 8 months ago (2014-04-09 11:20:18 UTC) #38
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 12:12:24 UTC) #39
commit-bot: I haz the power
Could not make sense out of svn commit message.
6 years, 8 months ago (2014-04-09 12:12:25 UTC) #40
Will Harris
6 years, 8 months ago (2014-04-09 20:39:25 UTC) #41
Message was sent while issue was closed. 
Committed patchset #1 manually as r262791 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698