Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 22929038: Add -DSIGNAL_PROVIDED to nacl build. (Closed)

Created:
7 years, 4 months ago by Sam Clegg
Modified:
7 years, 4 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-newlib.git@master
Visibility:
Public.

Description

Add -DSIGNAL_PROVIDED to NaCl build. This change makes -DSIGNAL_PROVIDED the default for the NaCl target which will bring the PNaCl build inline with the x86 and arm builds which define this on the command line. This define tells newlib to assume that the OS provides the signal/raise/kill functions and newlib should not include its own internal versions of these. Once this lands that command line flags can be removed from the other builds. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3646 TEST= ./build.sh libs and manual verification R=mseaborn@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-newlib.git;a=commit;h=ff87898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M newlib/configure.host View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Sam Clegg
7 years, 4 months ago (2013-08-23 00:59:51 UTC) #1
Mark Seaborn
Please add a BUG= field to the commit message. Then LGTM.
7 years, 4 months ago (2013-08-23 15:49:48 UTC) #2
Sam Clegg
Committed patchset #1 manually as rb80e213 (presubmit successful).
7 years, 4 months ago (2013-08-23 16:54:45 UTC) #3
Sam Clegg
7 years, 4 months ago (2013-08-23 17:05:03 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as rff87898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698