tests/lib/convert/utf82_test.dart - Issue 22929022: Treat negative utf8-units the same way as other broken encodings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/convert/utf82_test.dart

Issue 22929022: Treat negative utf8-units the same way as other broken encodings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/lib/convert/utf82_test.dart

diff --git a/tests/lib/convert/utf82_test.dart b/tests/lib/convert/utf82_test.dart

index b52f240ccdabc98b5a1f2b75c9ab6d4c92aa1fb7..e3a581153e3ba382f56d4fb1d20474d860ad3236 100644

--- a/tests/lib/convert/utf82_test.dart

+++ b/tests/lib/convert/utf82_test.dart

@@ -50,7 +50,13 @@ final TESTS = [

[ 0xC0, 0x80 ],

[ 0xC1, 0x80 ],

// Outside valid range.

- [ 0xF4, 0xBF, 0xBF, 0xBF ]];

+ [ 0xF4, 0xBF, 0xBF, 0xBF ],

+ // Negative

+ [ -0x01 ],

+ [ -0xFF ],

+ [ -0x80000000 ],

+ [ -0x40000000 ],

+ [ -0x80000000000000000]];

final TESTS2 = [

// Test that 0xC0|1, 0x80 does not eat the next character.

« no previous file with comments | « sdk/lib/convert/utf.dart ('k') | no next file » | no next file with comments »