Source/core/platform/graphics/ImageBuffer.cpp - Issue 22929012: Change Canvas2DLayerBridge to stay alive until last mailbox is returned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/platform/graphics/ImageBuffer.cpp

Issue 22929012: Change Canvas2DLayerBridge to stay alive until last mailbox is returned. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Make prepareMailbox return false during tear-down Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/platform/graphics/ImageBuffer.cpp

diff --git a/Source/core/platform/graphics/ImageBuffer.cpp b/Source/core/platform/graphics/ImageBuffer.cpp

index 48f2f54951c38fc7cdced7bee47c1be5477d7df3..25200f044fc849e6e8f199a9f86aeb9ef49fc7a2 100644

--- a/Source/core/platform/graphics/ImageBuffer.cpp

+++ b/Source/core/platform/graphics/ImageBuffer.cpp

@@ -61,7 +61,7 @@ using namespace std;

namespace WebCore {

-static SkCanvas* createAcceleratedCanvas(const IntSize& size, OwnPtr<Canvas2DLayerBridge>* outLayerBridge, OpacityMode opacityMode)

+static SkCanvas* createAcceleratedCanvas(const IntSize& size, RefPtr<Canvas2DLayerBridge>* outLayerBridge, OpacityMode opacityMode)

{

RefPtr<GraphicsContext3D> context3D = SharedGraphicsContext3D::get();

if (!context3D)

@@ -174,7 +174,7 @@ GraphicsContext* ImageBuffer::context() const

bool ImageBuffer::isValid() const

{

- if (m_layerBridge.get())

+ if (m_layerBridge)

return const_cast<Canvas2DLayerBridge*>(m_layerBridge.get())->isValid();

return true;

}