Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cflags/gyptest-cflags.py

Issue 22929009: Ninja on mac and win should also read CFLAGS/CXXFLAGS. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cflags/gyptest-cflags.py
===================================================================
--- test/cflags/gyptest-cflags.py (revision 1698)
+++ test/cflags/gyptest-cflags.py (working copy)
@@ -24,10 +24,7 @@
os.environ.clear()
os.environ.update(env_stack.pop())
-formats = ['make']
-if sys.platform.startswith('linux'):
- # Only Linux ninja generator supports CFLAGS.
- formats.append('ninja')
+formats = ['make', 'ninja']
test = TestGyp.TestGyp(formats=formats)
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698