Issue 22929009: Ninja on mac and win should also read CFLAGS/CXXFLAGS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22929009: Ninja on mac and win should also read CFLAGS/CXXFLAGS. (Closed)

Created:
7 years, 4 months ago by tony

Modified:
7 years, 4 months ago

Reviewers:
Paweł Hajdan Jr., scottmg

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Ninja on mac and win should also read CFLAGS/CXXFLAGS. Enable the code on Win/Mac as well as Linux. R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1699

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -17 lines)			Patch
	M	pylib/gyp/generator/ninja.py	View		1 chunk	+9 lines, -13 lines	0 comments	Download
	M	test/cflags/gyptest-cflags.py	View		1 chunk	+1 line, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

tony

I tested this manually on Mac, Win and Linux and it passes for me.

7 years, 4 months ago (2013-08-19 23:42:38 UTC) #1

tony

7 years, 4 months ago (2013-08-20 00:48:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1699 (presubmit successful).