Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2292893003: Remove Blink WTF GYP files. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Blink WTF GYP files. Inlines sources into GN build. Committed: https://crrev.com/815cc320b4bce2368a8076ebbf71be0eeb13f43e Cr-Commit-Position: refs/heads/master@{#415411}

Patch Set 1 #

Patch Set 2 : dotfile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+240 lines, -508 lines) Patch
M .gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/wtf/BUILD.gn View 3 chunks +240 lines, -10 lines 0 comments Download
D third_party/WebKit/Source/wtf/wtf.gyp View 1 chunk +0 lines, -160 lines 0 comments Download
D third_party/WebKit/Source/wtf/wtf.gypi View 1 chunk +0 lines, -244 lines 0 comments Download
D third_party/WebKit/Source/wtf/wtf_tests.gyp View 1 chunk +0 lines, -93 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
brettw
4 years, 3 months ago (2016-08-30 18:25:22 UTC) #2
brettw
dotfile
4 years, 3 months ago (2016-08-30 18:25:28 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-30 20:12:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292893003/20001
4 years, 3 months ago (2016-08-30 20:21:39 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 20:35:27 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 20:38:10 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/815cc320b4bce2368a8076ebbf71be0eeb13f43e
Cr-Commit-Position: refs/heads/master@{#415411}

Powered by Google App Engine
This is Rietveld 408576698