Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2292893002: Revert of Disable PasswordManagerBrowserTestBase.InternalsPage on Mac (Closed)

Created:
4 years, 3 months ago by vabr (Chromium)
Modified:
4 years, 3 months ago
Reviewers:
vasilii
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable PasswordManagerBrowserTestBase.InternalsPage on Mac (patchset #1 id:1 of https://codereview.chromium.org/2287143003/ ) Reason for revert: As leonhsl@ noted on https://codereview.chromium.org/2270333002/, the test failures only happened when the Mojo change https://codereview.chromium.org/2216463002 was on the trunk. Looking at the list of flakes [1], the revision numbers speak clearly: 413708 = Mojo change went in 413716 = first flake recorded 413923 = last flake recorded 413934 = Mojo change reverted Therefore the revert is not needed, the Mojo change needs to be fixed before relanding. [1] https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyNwsSBUZsYWtlIixQYXNzd29yZE1hbmFnZXJCcm93c2VyVGVzdEJhc2UuSW50ZXJuYWxzUGFnZQw Original issue's description: > Disable PasswordManagerBrowserTestBase.InternalsPage on Mac > > The test flakes on Mac. > > BUG=640737 > TBR=vasilii@chromium.org > > Committed: https://crrev.com/2683579867440a6ead8e06329f00bd7d0b3a1ce2 > Cr-Commit-Position: refs/heads/master@{#414996} TBR=vasilii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=640737 Committed: https://crrev.com/201fbb175db0902e4d9041eee0c4bdfb5c304aba Cr-Commit-Position: refs/heads/master@{#415248}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
vabr (Chromium)
Created Revert of Disable PasswordManagerBrowserTestBase.InternalsPage on Mac
4 years, 3 months ago (2016-08-30 08:51:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292893002/1
4 years, 3 months ago (2016-08-30 08:51:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 08:52:54 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 08:54:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/201fbb175db0902e4d9041eee0c4bdfb5c304aba
Cr-Commit-Position: refs/heads/master@{#415248}

Powered by Google App Engine
This is Rietveld 408576698