Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: ui/file_manager/file_manager/background/js/mock_volume_manager.js

Issue 2292873003: Divide volume_manager.js into files for each classes and extract interfaces from them. (Closed)
Patch Set: Address comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/background/js/mock_volume_manager.js
diff --git a/ui/file_manager/file_manager/background/js/mock_volume_manager.js b/ui/file_manager/file_manager/background/js/mock_volume_manager.js
index 74ff74eed1de4d6b6edef5eaea4e668149c0e686..cddbeb2c64a0e2dddcb6e37e79a919c380d56fb0 100644
--- a/ui/file_manager/file_manager/background/js/mock_volume_manager.js
+++ b/ui/file_manager/file_manager/background/js/mock_volume_manager.js
@@ -7,7 +7,7 @@
* @constructor
*/
function MockVolumeManager() {
- this.volumeInfoList = new VolumeInfoList();
+ this.volumeInfoList = new VolumeInfoListImpl();
this.driveConnectionState = {
type: VolumeManagerCommon.DriveConnectionType.ONLINE
};
@@ -33,7 +33,7 @@ MockVolumeManager.instance_ = null;
MockVolumeManager.installMockSingleton = function(opt_singleton) {
MockVolumeManager.instance_ = opt_singleton || new MockVolumeManager();
- VolumeManager.getInstance = function() {
+ volumeManagerFactory.getInstance = function() {
return Promise.resolve(MockVolumeManager.instance_);
};
};
@@ -74,14 +74,14 @@ MockVolumeManager.prototype.getVolumeInfo = function(entry) {
*/
MockVolumeManager.prototype.getLocationInfo = function(entry) {
if (util.isFakeEntry(entry)) {
- return new EntryLocation(this.volumeInfoList.item(0), entry.rootType, true,
- true);
+ return new EntryLocationImpl(this.volumeInfoList.item(0), entry.rootType,
+ true, true);
}
if (entry.filesystem.name === VolumeManagerCommon.VolumeType.DRIVE) {
var volumeInfo = this.volumeInfoList.item(0);
var isRootEntry = entry.fullPath === '/root';
- return new EntryLocation(volumeInfo, VolumeManagerCommon.RootType.DRIVE,
+ return new EntryLocationImpl(volumeInfo, VolumeManagerCommon.RootType.DRIVE,
isRootEntry, true);
}
@@ -93,7 +93,7 @@ MockVolumeManager.prototype.getLocationInfo = function(entry) {
* @return {VolumeInfo} Volume info.
*/
MockVolumeManager.prototype.getCurrentProfileVolumeInfo = function(volumeType) {
- return VolumeManager.prototype.getCurrentProfileVolumeInfo.call(
+ return VolumeManagerImpl.prototype.getCurrentProfileVolumeInfo.call(
this, volumeType);
};
@@ -165,7 +165,7 @@ MockVolumeManagerWrapper.instance_ = null;
MockVolumeManagerWrapper.installMockSingleton = function(opt_singleton) {
MockVolumeManagerWrapper.instance_ =
opt_singleton || new MockVolumeManagerWrapper();
- VolumeManager.getInstance = function() {
+ volumeManagerFactory.getInstance = function() {
return Promise.resolve(MockVolumeManagerWrapper.instance_);
};
};
@@ -207,13 +207,13 @@ MockVolumeManagerWrapper.prototype.getVolumeInfo = function(entry) {
*/
MockVolumeManagerWrapper.prototype.getLocationInfo = function(entry) {
if (util.isFakeEntry(entry)) {
- return new EntryLocation(this.volumeInfoList.item(0), entry.rootType, true,
- true);
+ return new EntryLocationImpl(this.volumeInfoList.item(0), entry.rootType,
+ true, true);
}
if (entry.filesystem.name === VolumeManagerCommon.VolumeType.DRIVE) {
var volumeInfo = this.volumeInfoList.item(0);
var isRootEntry = entry.fullPath === '/root';
- return new EntryLocation(volumeInfo, VolumeManagerCommon.RootType.DRIVE,
+ return new EntryLocationImpl(volumeInfo, VolumeManagerCommon.RootType.DRIVE,
isRootEntry, true);
}
throw new Error('Not implemented exception.');

Powered by Google App Engine
This is Rietveld 408576698