Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2292873002: [turbofan] Treat the INT32 state of a truncating binary op IC as number or oddball on 32-bit machin… (Closed)

Created:
4 years, 3 months ago by epertoso
Modified:
4 years, 3 months ago
Reviewers:
*Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Treat the INT32 state of a truncating binary op IC as number or oddball on 32-bit machines. This was causing a few unexpected deopt loops. BUG=v8:5320 Committed: https://crrev.com/bdf55662813082e711c1ad3307c0fa3d0b4dddbc Cr-Commit-Position: refs/heads/master@{#39019}

Patch Set 1 #

Patch Set 2 : Update. #

Total comments: 2

Patch Set 3 : Update. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -14 lines) Patch
M src/compiler/type-hint-analyzer.cc View 1 2 chunks +6 lines, -3 lines 0 comments Download
A + test/mjsunit/compiler/regress-5320.js View 1 2 1 chunk +22 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
epertoso
4 years, 3 months ago (2016-08-30 13:03:31 UTC) #7
Jarin
lgtm https://codereview.chromium.org/2292873002/diff/20001/test/mjsunit/compiler/regress-5320.js File test/mjsunit/compiler/regress-5320.js (right): https://codereview.chromium.org/2292873002/diff/20001/test/mjsunit/compiler/regress-5320.js#newcode36 test/mjsunit/compiler/regress-5320.js:36: % OptimizeFunctionOnNextCall(func); Remove space.
4 years, 3 months ago (2016-08-30 13:05:52 UTC) #8
epertoso
https://codereview.chromium.org/2292873002/diff/20001/test/mjsunit/compiler/regress-5320.js File test/mjsunit/compiler/regress-5320.js (right): https://codereview.chromium.org/2292873002/diff/20001/test/mjsunit/compiler/regress-5320.js#newcode36 test/mjsunit/compiler/regress-5320.js:36: % OptimizeFunctionOnNextCall(func); On 2016/08/30 13:05:52, Jarin wrote: > Remove ...
4 years, 3 months ago (2016-08-30 13:46:48 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292873002/40001
4 years, 3 months ago (2016-08-30 13:47:02 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-30 14:13:26 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 14:13:40 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bdf55662813082e711c1ad3307c0fa3d0b4dddbc
Cr-Commit-Position: refs/heads/master@{#39019}

Powered by Google App Engine
This is Rietveld 408576698