Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229283003: Applied changes to chromium tree for new NaCl toolchain directories. (Closed)

Created:
6 years, 8 months ago by David Yen
Modified:
6 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, binji, Sam Clegg, extensions-reviews_chromium.org
Visibility:
Public.

Description

Applied changes to chromium tree for new NaCl toolchain directories. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3816 TEST= trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262825

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M native_client_sdk/src/tools/lib/tests/get_shared_deps_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/tools/tests/create_nmf_test.py View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_support_extension/pnacl_support_extension.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
David Yen
Here are the changes required to get the chromium side working after I delete the ...
6 years, 8 months ago (2014-04-08 21:44:53 UTC) #1
Sam Clegg
lgtm
6 years, 8 months ago (2014-04-08 21:48:29 UTC) #2
David Yen
The CQ bit was checked by dyen@chromium.org
6 years, 8 months ago (2014-04-09 15:51:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/229283003/1
6 years, 8 months ago (2014-04-09 15:52:06 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 17:06:28 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60381
6 years, 8 months ago (2014-04-09 17:06:29 UTC) #6
David Yen
The CQ bit was checked by dyen@chromium.org
6 years, 8 months ago (2014-04-09 18:10:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/229283003/20001
6 years, 8 months ago (2014-04-09 18:10:22 UTC) #8
David Yen
The CQ bit was unchecked by dyen@chromium.org
6 years, 8 months ago (2014-04-09 18:10:27 UTC) #9
David Yen
Ping, it looks like I need a lgtm from Brad.
6 years, 8 months ago (2014-04-09 18:12:11 UTC) #10
bradnelson
lgtm
6 years, 8 months ago (2014-04-09 19:30:01 UTC) #11
David Yen
The CQ bit was checked by dyen@chromium.org
6 years, 8 months ago (2014-04-09 19:34:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/229283003/20001
6 years, 8 months ago (2014-04-09 19:34:57 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 21:40:44 UTC) #14
Message was sent while issue was closed. 
Change committed as 262825

Powered by Google App Engine
This is Rietveld 408576698