Disallow WKBackForwardListItem navigations for pushState pages.

Disallow WKBackForwardListItem navigations for pushState pages.

The WKWebViewConfiguration's |userScripts| are not injected when
navigating via BFLI to a page created using window.history.pushState.
This means that calling window.history navigation functions will
invoke WKWebView's non-overridden implementations, causing a mismatch
between the WKBackForwardList and NavigationManager.

BUG=none

Committed: https://crrev.com/540983ab54c3259bb9b548bfd8c1d95367fa15f2
Cr-Commit-Position: refs/heads/master@{#415114}

[kkhorimoto, 2016-08-29 23:58:24]

kkhorimoto@chromium.org changed reviewers:
+ eugenebut@chromium.org

[kkhorimoto, 2016-08-29 23:58:24]

This is a fix for b/30315469, which I've cc'd you on.

[Eugene But (OOO till 7-30), 2016-08-30 00:48:57]

Code lgtm. Are you sure that the comment is accurate?

https://codereview.chromium.org/2292773002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2292773002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:1858: // injected.  As a result, the
WKBackForwardList will become out of sync with
Sounds like if scripts are not injected than spoofing may happen. Is it really
the case?

[kkhorimoto, 2016-08-30 00:53:23]

Description was changed from

==========
Disallow WKBackForwardListItem navigations for pushState pages.

The WKWebViewConfiguration's |userScripts| are not injected when
navigating via BFLI to a page created using window.history.pushState.
This means that calling window.history navigation functions will
call WKWebView's non-overridden implementations, causing a mismatch
between the WKBackForwardList and NavigationManager.

BUG=none
==========

to

==========
Disallow WKBackForwardListItem navigations for pushState pages.

The WKWebViewConfiguration's |userScripts| are not injected when
navigating via BFLI to a page created using window.history.pushState.
This means that calling window.history navigation functions will
invoke WKWebView's non-overridden implementations, causing a mismatch
between the WKBackForwardList and NavigationManager.

BUG=none
==========

[kkhorimoto, 2016-08-30 00:54:41]

https://codereview.chromium.org/2292773002/diff/1/ios/web/web_state/ui/crw_we...
File ios/web/web_state/ui/crw_web_controller.mm (right):

https://codereview.chromium.org/2292773002/diff/1/ios/web/web_state/ui/crw_we...
ios/web/web_state/ui/crw_web_controller.mm:1858: // injected.  As a result, the
WKBackForwardList will become out of sync with
On 2016/08/30 00:48:57, Eugene But wrote:
> Sounds like if scripts are not injected than spoofing may happen. Is it really
> the case?

Sorry, the URL spoofing issue was the result of one of my speculative fixes.  In
ToT before this CL, the URL will match the displayed page, it's just not the URL
we expected to load because the wrong BFLI was used.

[kkhorimoto, 2016-08-30 00:54:45]

The CQ bit was checked by kkhorimoto@chromium.org

[kkhorimoto, 2016-08-30 00:54:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2292773002/#ps20001
(title: "Fix comment")

[commit-bot: I haz the power, 2016-08-30 02:16:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 04:47:11]

Description was changed from

==========
Disallow WKBackForwardListItem navigations for pushState pages.

The WKWebViewConfiguration's |userScripts| are not injected when
navigating via BFLI to a page created using window.history.pushState.
This means that calling window.history navigation functions will
invoke WKWebView's non-overridden implementations, causing a mismatch
between the WKBackForwardList and NavigationManager.

BUG=none
==========

to

==========
Disallow WKBackForwardListItem navigations for pushState pages.

The WKWebViewConfiguration's |userScripts| are not injected when
navigating via BFLI to a page created using window.history.pushState.
This means that calling window.history navigation functions will
invoke WKWebView's non-overridden implementations, causing a mismatch
between the WKBackForwardList and NavigationManager.

BUG=none
==========

[commit-bot: I haz the power, 2016-08-30 04:47:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 04:48:35]

Description was changed from

==========
Disallow WKBackForwardListItem navigations for pushState pages.

The WKWebViewConfiguration's |userScripts| are not injected when
navigating via BFLI to a page created using window.history.pushState.
This means that calling window.history navigation functions will
invoke WKWebView's non-overridden implementations, causing a mismatch
between the WKBackForwardList and NavigationManager.

BUG=none
==========

to

==========
Disallow WKBackForwardListItem navigations for pushState pages.

The WKWebViewConfiguration's |userScripts| are not injected when
navigating via BFLI to a page created using window.history.pushState.
This means that calling window.history navigation functions will
invoke WKWebView's non-overridden implementations, causing a mismatch
between the WKBackForwardList and NavigationManager.

BUG=none

Committed: https://crrev.com/540983ab54c3259bb9b548bfd8c1d95367fa15f2
Cr-Commit-Position: refs/heads/master@{#415114}
==========

[commit-bot: I haz the power, 2016-08-30 04:48:36]

Patchset 2 (id:??) landed as
https://crrev.com/540983ab54c3259bb9b548bfd8c1d95367fa15f2
Cr-Commit-Position: refs/heads/master@{#415114}