Commit a new download to history db immediately on Android

Commit a new download to history db immediately on Android

If browser is killed when a download is just created, the
download is forever lost.
User can no longer resume the download.
And a temporary file is left forever on the disk.
On desktop platforms, this may not be a big issue as users
can easily go to the download dir to delete that file.
However, it is not very straight forward to access the file maanger.
This change commits the CreateDownload() to history db immediately on Android,
rather than waiting for the scheduled time interval.
This will greatly reduce the chance of the above problem, though
very unlikely possible.

BUG=636101
Committed: https://crrev.com/e8b7133f781db0fe40ba704b9655d16ba3c2be7e
Cr-Commit-Position: refs/heads/master@{#415334}

[qinmin, 2016-08-29 21:21:25]

qinmin@chromium.org changed reviewers:
+ asanka@chromium.org, benjhayden@chromium.org, sky@chromium.org

[qinmin, 2016-08-29 21:21:25]

PTAL

[sky, 2016-08-29 22:58:05]

https://codereview.chromium.org/2292733002/diff/1/components/history/core/bro...
File components/history/core/browser/history_backend.cc (right):

https://codereview.chromium.org/2292733002/diff/1/components/history/core/bro...
components/history/core/browser/history_backend.cc:1183: Commit();
Please add a comment here as to why this is special (similar to the description
in your patch).

[qinmin, 2016-08-30 00:08:06]

https://codereview.chromium.org/2292733002/diff/1/components/history/core/bro...
File components/history/core/browser/history_backend.cc (right):

https://codereview.chromium.org/2292733002/diff/1/components/history/core/bro...
components/history/core/browser/history_backend.cc:1183: Commit();
On 2016/08/29 22:58:05, sky wrote:
> Please add a comment here as to why this is special (similar to the
description
> in your patch).

Done.

[sky, 2016-08-30 03:21:22]

LGTM

https://codereview.chromium.org/2292733002/diff/20001/components/history/core...
File components/history/core/browser/history_backend.cc (right):

https://codereview.chromium.org/2292733002/diff/20001/components/history/core...
components/history/core/browser/history_backend.cc:1186: // uncommitted download
entry before browser kill.
'before browser kill' -> 'if browser is killed'

[benjhayden, 2016-08-30 04:20:40]

I defer to sky since I don't remember this code.

[benjhayden, 2016-08-30 04:20:46]

benjhayden@chromium.org changed reviewers:
- benjhayden@chromium.org

[qinmin, 2016-08-30 16:31:33]

https://codereview.chromium.org/2292733002/diff/20001/components/history/core...
File components/history/core/browser/history_backend.cc (right):

https://codereview.chromium.org/2292733002/diff/20001/components/history/core...
components/history/core/browser/history_backend.cc:1186: // uncommitted download
entry before browser kill.
On 2016/08/30 03:21:21, sky wrote:
> 'before browser kill' -> 'if browser is killed'

Done.

[qinmin, 2016-08-30 16:31:37]

The CQ bit was checked by qinmin@chromium.org

[qinmin, 2016-08-30 16:31:38]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2292733002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-08-30 16:31:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 17:19:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-30 17:20:58]

Description was changed from

==========
Commit a new download to history db immediately on Android

If browser is killed when a download is just created, the
download is forever lost.
User can no longer resume the download.
And a temporary file is left forever on the disk.
On desktop platforms, this may not be a big issue as users
can easily go to the download dir to delete that file.
However, it is not very straight forward to access the file maanger.
This change commits the CreateDownload() to history db immediately on Android,
rather than waiting for the scheduled time interval.
This will greatly reduce the chance of the above problem, though
very unlikely possible.

BUG=636101
==========

to

==========
Commit a new download to history db immediately on Android

If browser is killed when a download is just created, the
download is forever lost.
User can no longer resume the download.
And a temporary file is left forever on the disk.
On desktop platforms, this may not be a big issue as users
can easily go to the download dir to delete that file.
However, it is not very straight forward to access the file maanger.
This change commits the CreateDownload() to history db immediately on Android,
rather than waiting for the scheduled time interval.
This will greatly reduce the chance of the above problem, though
very unlikely possible.

BUG=636101

Committed: https://crrev.com/e8b7133f781db0fe40ba704b9655d16ba3c2be7e
Cr-Commit-Position: refs/heads/master@{#415334}
==========

[commit-bot: I haz the power, 2016-08-30 17:21:00]

Patchset 3 (id:??) landed as
https://crrev.com/e8b7133f781db0fe40ba704b9655d16ba3c2be7e
Cr-Commit-Position: refs/heads/master@{#415334}