Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2292723002: [DevTools] Make accessibility a remote module (Closed)

Created:
4 years, 3 months ago by aboxhall
Modified:
4 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make accessibility a remote module BUG=390254 Committed: https://crrev.com/86c444951f233524bc9263dc8906083b8fa3cb29 Cr-Commit-Position: refs/heads/master@{#415223}

Patch Set 1 #

Patch Set 2 : Don't include accessibility in generate_devtools_grd #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/devtools.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
aboxhall
4 years, 3 months ago (2016-08-29 21:22:21 UTC) #3
dgozman
lgtm
4 years, 3 months ago (2016-08-29 21:29:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292723002/20001
4 years, 3 months ago (2016-08-30 02:16:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 06:28:35 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 06:31:23 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/86c444951f233524bc9263dc8906083b8fa3cb29
Cr-Commit-Position: refs/heads/master@{#415223}

Powered by Google App Engine
This is Rietveld 408576698