Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2292713002: Clear the scaled bitmap before drawing into it for huge UIResources. (Closed)

Created:
4 years, 3 months ago by danakj
Modified:
4 years, 3 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, eugenis, Irfan, piman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear the scaled bitmap before drawing into it for huge UIResources. When the UIResource is larger than max_texture_size, we downsample it into a smaller bitmap. However floating point precision can cause some of the pixels to not be fully initialized if the scale doesn't exactly cause the bitmap to be filled. So clear the bitmap before doing this scaling operation into it. R=enne BUG=642011 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/8d737f8882e170b93ec3224642fa7f6a552817f3 Cr-Commit-Position: refs/heads/master@{#415124}

Patch Set 1 #

Patch Set 2 : uninit-scrollbars: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -13 lines) Patch
M cc/test/data/spiral_64_scale.png View 1 Binary file 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_scrollbars.cc View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
danakj
4 years, 3 months ago (2016-08-29 20:55:21 UTC) #3
enne (OOO)
lgtm
4 years, 3 months ago (2016-08-30 00:43:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292713002/20001
4 years, 3 months ago (2016-08-30 02:16:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 04:57:13 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 05:00:20 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d737f8882e170b93ec3224642fa7f6a552817f3
Cr-Commit-Position: refs/heads/master@{#415124}

Powered by Google App Engine
This is Rietveld 408576698