chromeos: Remove unused NFC D-Bus client library

chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dpranke@chromium.org

Committed: https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7
Cr-Commit-Position: refs/heads/master@{#415321}

[James Cook, 2016-08-29 20:46:05]

Description was changed from

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
==========

to

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[James Cook, 2016-08-29 20:46:11]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-08-29 20:48:48]

The CQ bit was unchecked by jamescook@chromium.org

[James Cook, 2016-08-29 20:49:47]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-08-29 21:09:21]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-08-29 21:23:42]

jamescook@chromium.org changed reviewers:
+ reillyg@chromium.org, stevenjb@chromium.org

[James Cook, 2016-08-29 21:23:44]

stevenjb, PTAL at chromeos/dbus
reillyg, PTAL at device/nfc

I talked to adlr@ and alberto@ -- there are no Chromebooks with NFC and they're
OK with deleting the code.

I deleted the "cross platform" C++ base classes in device/nfc because they were
only used as bases classes for Chrome OS code.

I left the Android Java version and the mojo bindings untouched.

[stevenjb, 2016-08-29 21:35:28]

Wow, that's a lot of services. If we revive this in the future we should really
consider wrapping this as a separate service that talks to chrome via a mojo
interface.

LGTM!

[Reilly Grant (use Gerrit), 2016-08-29 23:26:37]

lgtm, I didn't know there was this much red in the whole galaxy.

[James Cook, 2016-08-29 23:42:36]

jamescook@chromium.org changed reviewers:
+ michaelpg@chromium.org

[James Cook, 2016-08-29 23:42:36]

michaelpg, can I get OWNERS for removing some unused webui in
chrome/browser/ui/webui ?

[stevenjb, 2016-08-29 23:48:01]

James, I should be an owner for that directory?

[michaelpg, 2016-08-30 01:20:54]

On 2016/08/29 23:42:36, James Cook wrote:
> michaelpg, can I get OWNERS for removing some unused webui in
> chrome/browser/ui/webui ?

rslgtm

[michaelpg, 2016-08-30 01:21:10]

On 2016/08/30 01:20:54, michaelpg wrote:
> On 2016/08/29 23:42:36, James Cook wrote:
> > michaelpg, can I get OWNERS for removing some unused webui in
> > chrome/browser/ui/webui ?
> 
> rslgtm

or... rs lgtm

[James Cook, 2016-08-30 15:21:00]

Description was changed from

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[James Cook, 2016-08-30 15:21:00]

jamescook@chromium.org changed reviewers:
+ dpranke@google.com

[James Cook, 2016-08-30 15:21:15]

Description was changed from

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dpranke@chromium.org
==========

[James Cook, 2016-08-30 15:21:58]

TBR dpranke for deleting a TODO in build/gn_migration.gypi for a target I just
removed

[James Cook, 2016-08-30 15:22:09]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-08-30 15:22:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, reillyg@chromium.org, michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/2292703002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-08-30 15:22:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dirk Pranke, 2016-08-30 16:02:45]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-08-30 16:02:46]

lgtm

[commit-bot: I haz the power, 2016-08-30 16:51:24]

Description was changed from

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dpranke@chromium.org
==========

to

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dpranke@chromium.org
==========

[commit-bot: I haz the power, 2016-08-30 16:51:26]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-30 16:54:49]

Description was changed from

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dpranke@chromium.org
==========

to

==========
chromeos: Remove unused NFC D-Bus client library

Remove the chrome D-Bus bindings code and web UI test code. We can revive
them from git history if we need them again.

BUG=641996
TEST=compiles
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
TBR=dpranke@chromium.org

Committed: https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7
Cr-Commit-Position: refs/heads/master@{#415321}
==========

[commit-bot: I haz the power, 2016-08-30 16:54:50]

Patchset 5 (id:??) landed as
https://crrev.com/64996a9695131f29dc8c4e3f6b1591f50970b7d7
Cr-Commit-Position: refs/heads/master@{#415321}