Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: Source/core/page/NavigatorBase.h

Issue 22927015: Introduce NavigatorID IDL interface (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/page/NavigatorBase.h
diff --git a/Source/core/page/NavigatorBase.h b/Source/core/page/NavigatorBase.h
index dcc9d067c68ebd5c3982bf4297d82f71c95b92ba..f6772abe875e5e81b35aba0c8443c3ab00ee13e7 100644
--- a/Source/core/page/NavigatorBase.h
+++ b/Source/core/page/NavigatorBase.h
@@ -32,13 +32,16 @@ namespace WebCore {
class NavigatorBase {
public:
- String appName() const;
- String appVersion() const;
virtual String userAgent() const = 0;
- String platform() const;
+ // FIXME: The following should be moved to NavigatorID and
do-not-use 2013/08/20 11:05:06 Planning to address this in a follow up patch. Sho
+ // exposed on WorkerNavigator as well.
String appCodeName() const;
String product() const;
+
+ // FIXME: The following is not part of the specification and is only
do-not-use 2013/08/20 11:05:06 Planning to address this in a follow-up patch. My
haraken 2013/08/20 12:52:52 +1 to moving the methods to Navigator.idl only.
arv (Not doing code reviews) 2013/08/20 13:40:44 +1 and add deprecation warnings on these as well.
+ // exposed on Navigator. It should be moved to Navigator (or exposed
+ // on WorkerNavigator as well).
String productSub() const;
String vendor() const;
String vendorSub() const;

Powered by Google App Engine
This is Rietveld 408576698