GN: ft and fc as optionals

GN: ft and fc as optionals

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292613002

Committed: https://skia.googlesource.com/skia/+/3cc22180561ae17a64ff0e0f9ba173eac149009e

[mtklein_C, 2016-08-29 18:32:56]

Description was changed from

==========
GN: ft and fc as optionals

BUG=skia:
==========

to

==========
GN: ft and fc as optionals

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292613002
==========

[mtklein_C, 2016-08-29 18:34:41]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 18:34:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein_C, 2016-08-29 18:35:57]

mtklein@chromium.org changed reviewers:
+ bungeman@google.com

[bungeman-skia, 2016-08-29 18:49:38]

Aside from the naming, lgtm

https://codereview.chromium.org/2292613002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2292613002/diff/1/BUILD.gn#newcode308
BUILD.gn:308: optional("typeface_fontconfig") {
I think this should be named fontmgr_fontconfig. FreeType provides the
typefaces, FontConfig provides the font management.

[mtklein_C, 2016-08-29 18:55:31]

On 2016/08/29 at 18:49:38, bungeman wrote:
> Aside from the naming, lgtm
> 
> https://codereview.chromium.org/2292613002/diff/1/BUILD.gn
> File BUILD.gn (right):
> 
> https://codereview.chromium.org/2292613002/diff/1/BUILD.gn#newcode308
> BUILD.gn:308: optional("typeface_fontconfig") {
> I think this should be named fontmgr_fontconfig. FreeType provides the
typefaces, FontConfig provides the font management.

Done.

[mtklein_C, 2016-08-29 18:55:33]

The CQ bit was checked by mtklein@chromium.org

[mtklein_C, 2016-08-29 18:55:33]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/2292613002/#ps20001
(title: "rename")

[commit-bot: I haz the power, 2016-08-29 18:55:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 20:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 20:18:26]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[mtklein, 2016-08-29 20:21:13]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-08-29 20:22:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 20:26:17]

Description was changed from

==========
GN: ft and fc as optionals

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292613002
==========

to

==========
GN: ft and fc as optionals

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2292613002

Committed:
https://skia.googlesource.com/skia/+/3cc22180561ae17a64ff0e0f9ba173eac149009e
==========

[commit-bot: I haz the power, 2016-08-29 20:26:18]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/3cc22180561ae17a64ff0e0f9ba173eac149009e