Enable password saving for dynamic password forms

chrome/browser/password_manager/password_manager_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/command_line.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/infobars/confirm_infobar_delegate.h"
 #include "chrome/browser/infobars/infobar_service.h"
@@ skipping 158 matching lines @@
   NavigationObserver observer(WebContents());
   std::string fill_and_submit =
       "document.getElementById('username_field').value = 'temp';"
       "document.getElementById('password_field').value = 'random';"
       "document.getElementById('submit_button').click()";
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
   observer.Wait();
   EXPECT_TRUE(observer.infobar_shown());
 }
 
+IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest,
+                       PromptForDynamicForm) {
+  ASSERT_TRUE(test_server()->Start());
+
+  GURL url = test_server()->GetURL("files/password/dynamic_password_form.html");
+  ui_test_utils::NavigateToURL(browser(), url);

[Garrett Casto, 2013/09/13 18:30:05]

Use NavigateToFile() for this or else the test is going to be flaky.

[guohui, 2013/09/13 20:07:57]

Done.

+
+  // Fill the dynamic password form and submit.
+  NavigationObserver observer(WebContents());
+  std::string fill_and_submit =
+      "document.getElementById('create_form_button').click();"
+      "window.setTimeout(function() {"

[Garrett Casto, 2013/09/13 18:30:05]

Out of curiosity, why do you need to use a setTimeout function? Is it because
document.dynamic_form isn't visible right after you call click()?

[guohui, 2013/09/13 20:07:57]

yes, because dynamic_form is inserted in click handler, and a click events is
triggered asynchronously.

+      "  document.dynamic_form.username.value = 'temp';"
+      "  document.dynamic_form.password.value = 'random';"
+      "  document.dynamic_form.submit();"
+      "}, 0)";
+  ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_submit));
+  observer.Wait();
+  EXPECT_TRUE(observer.infobar_shown());
+}
+
 IN_PROC_BROWSER_TEST_F(PasswordManagerBrowserTest, NoPromptForNavigation) {
   NavigateToFile("/password/password_form.html");
 
   // Don't fill the password form, just navigate away. Shouldn't prompt.
   NavigationObserver observer(WebContents());
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(),
                                      "window.location.href = 'done.html';"));
   observer.Wait();
   EXPECT_FALSE(observer.infobar_shown());
 }
@@ skipping 78 matching lines @@
   // cases where the element that users click on isn't a submit button.
   NavigationObserver observer(WebContents());
   std::string fill_and_navigate =
       "document.getElementById('username_field').value = 'temp';"
       "document.getElementById('password_field').value = 'random';"
       "send_xhr()";
   ASSERT_TRUE(content::ExecuteScript(RenderViewHost(), fill_and_navigate));
   observer.Wait();
   EXPECT_FALSE(observer.infobar_shown());
 }