Issue 22926032: Win: implement shared memory Device Orientation fetcher.

Issue 22926032: Win: implement shared memory Device Orientation fetcher. (Closed)

Created:
7 years, 4 months ago by timvolodine

Modified:
7 years, 3 months ago

Reviewers:
bulach, piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Michael van Ouwerkerk

Base URL:
https://chromium.googlesource.com/chromium/src.git@Aug-23-mac-fetcher

Visibility:
Public.

More Reviews

Description

Win: implement shared memory Device Orientation fetcher. Implement Device Orientation data fetcher for the Windows 7 or greater platform. The fetcher uses 3D inclinometer windows sensor to update the orientation information in the shared memory buffer. BUG=261165 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221700

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : some fixes #

Patch Set 4 : more fixes #

Patch Set 5 : |orientation_buffer_|->|buffer_| #

Patch Set 6 : fix Start() method signature #

Patch Set 7 : rebased #

Patch Set 8 : modified to use InitSharedMemoryBuffer() to compile on win #

Total comments: 4

Patch Set 9 : fixed comments + rebased #

Patch Set 10 : fix compilation issue -- use GetSharedMemoryBuffer #

Patch Set 11 : rebased #

Patch Set 12 : fixes to win build #

Patch Set 13 : try fix include #

Patch Set 14 : fix compile on win #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -56 lines)			Patch
M	content/browser/device_orientation/data_fetcher_shared_memory.h	View	1 2 3 4 5 6 7 8 9 10	2 chunks	+8 lines, -0 lines	0 comments	Download
A +	content/browser/device_orientation/data_fetcher_shared_memory_win.cc	View	1 2 3 4 5 6 7 8 9 10 11 12 13	6 chunks	+70 lines, -56 lines	0 comments	Download
M	content/content_browser.gypi	View	1 2 3 4 5 6 7 8	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, thanks! just nits: https://codereview.chromium.org/22926032/diff/34001/content/browser/device_orientation/data_fetcher_shared_memory.h File content/browser/device_orientation/data_fetcher_shared_memory.h (right): https://codereview.chromium.org/22926032/diff/34001/content/browser/device_orientation/data_fetcher_shared_memory.h#newcode17 content/browser/device_orientation/data_fetcher_shared_memory.h:17: #if defined(OS_WIN) nit: could commbine ...

7 years, 3 months ago (2013-09-02 13:29:34 UTC) #2

timvolodine

thanks! https://codereview.chromium.org/22926032/diff/34001/content/browser/device_orientation/data_fetcher_shared_memory.h File content/browser/device_orientation/data_fetcher_shared_memory.h (right): https://codereview.chromium.org/22926032/diff/34001/content/browser/device_orientation/data_fetcher_shared_memory.h#newcode17 content/browser/device_orientation/data_fetcher_shared_memory.h:17: #if defined(OS_WIN) On 2013/09/02 13:29:34, bulach wrote: > ...

7 years, 3 months ago (2013-09-03 17:14:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/22926032/45001

7 years, 3 months ago (2013-09-03 23:18:44 UTC) #6

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 3 months ago (2013-09-04 01:17:58 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/22926032/79001

7 years, 3 months ago (2013-09-06 11:24:20 UTC) #8

Message was sent while issue was closed.

Change committed as 221700

Expand Messages | Collapse Messages