Sparse IO: Allow failover to network in debug builds

net/disk_cache/simple/simple_entry_impl.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/disk_cache/simple/simple_entry_impl.h"
 
 #include <algorithm>
 #include <cstring>
 #include <vector>
 
@@ skipping 478 matching lines @@
 void SimpleEntryImpl::CancelSparseIO() {
   DCHECK(io_thread_checker_.CalledOnValidThread());
   // TODO(gavinp): Determine if the simple backend should support sparse data.
   NOTIMPLEMENTED();
 }
 
 int SimpleEntryImpl::ReadyForSparseIO(const CompletionCallback& callback) {
   DCHECK(io_thread_checker_.CalledOnValidThread());
   // TODO(gavinp): Determine if the simple backend should support sparse data.
   NOTIMPLEMENTED();
+#if defined(OS_ANDROID)

[rvargas (doing something else), 2013/08/28 21:35:47]

There should not be an ifdef here.

[gavinp, 2013/08/28 21:41:25]

This was specifically requested by the TPM to make this CL mergeable. Perhaps
the thing to do is add a TODO() to remove this #ifdef after the change has baked
on canary for a day and then been merged?

[pasko, 2013/08/28 21:56:28]

I don't like this ifdef either, and maybe this one is a bit of extreme, just
wanted the TPM to feel cozy. I left a TODO in http_cache_transaction.cc to
remove this conditionalizing, and it then did not make much sense to replicate
that TODO at every hunk in the patch.

[rvargas (doing something else), 2013/08/28 22:33:40]

I just commented on the bug. I understand the other ifdef... this one is out of
place IMO. (but don't take this comment as blocking the CL in any way, because
it doesn't break anything)

+  return net::ERR_NOT_IMPLEMENTED;
+#else
   return net::ERR_FAILED;
+#endif
 }
 
 SimpleEntryImpl::~SimpleEntryImpl() {
   DCHECK(io_thread_checker_.CalledOnValidThread());
   DCHECK_EQ(0U, pending_operations_.size());
   DCHECK(state_ == STATE_UNINITIALIZED || state_ == STATE_FAILURE);
   DCHECK(!synchronous_entry_);
   RemoveSelfFromBackend();
   net_log_.EndEvent(net::NetLog::TYPE_SIMPLE_CACHE_ENTRY);
 }
@@ skipping 685 matching lines @@
     } else {
       type = conflicting ? WRITE_FOLLOWS_CONFLICTING_WRITE
                          : WRITE_FOLLOWS_NON_CONFLICTING_WRITE;
     }
   }
   UMA_HISTOGRAM_ENUMERATION(
       "SimpleCache.WriteDependencyType", type, WRITE_DEPENDENCY_TYPE_MAX);
 }
 
 }  // namespace disk_cache